From: Phil Auld <pauld@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Mel Gorman <mgorman@techsingularity.net>,
Ingo Molnar <mingo@redhat.com>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Valentin Schneider <valentin.schneider@arm.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] sched/fair: Age the average idle time
Date: Tue, 15 Jun 2021 17:13:28 -0400 [thread overview]
Message-ID: <YMkX+MMVV0aMjmR8@lorien.usersys.redhat.com> (raw)
In-Reply-To: <20210615204228.GB4272@worktop.programming.kicks-ass.net>
On Tue, Jun 15, 2021 at 10:42:28PM +0200 Peter Zijlstra wrote:
> On Tue, Jun 15, 2021 at 12:16:11PM +0100, Mel Gorman wrote:
> > From: Peter Zijlstra (Intel) <peterz@infradead.org>
> >
> > This is a partial forward-port of Peter Ziljstra's work first posted
> > at https://lore.kernel.org/lkml/20180530142236.667774973@infradead.org/.
>
> It's patches 2 and 3 together, right?
>
> > His Signed-off has been removed because it is modified but will be restored
> > if he says it's still ok.
>
> I suppose the SoB will auto-magically re-appear if I apply it :-)
>
> > The patch potentially matters when a socket was multiple LLCs as the
> > maximum search depth is lower. However, some of the test results were
> > suspiciously good (e.g. specjbb2005 gaining 50% on a Zen1 machine) and
> > other results were not dramatically different to other mcahines.
> >
> > Given the nature of the patch, Peter's full series is not being forward
> > ported as each part should stand on its own. Preferably they would be
> > merged at different times to reduce the risk of false bisections.
>
> I'm tempted to give it a go.. anyone object?
>
Fwiw, I have some perf tests running on v1. But I don't know if the
results will be in before I'm AFK next week. I suppose we could pull
it back out if something really bad comes up.
Seems like a reasonable change to me on the surface.
Cheers,
Phil
--
next prev parent reply other threads:[~2021-06-15 21:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 11:16 [PATCH v2] sched/fair: Age the average idle time Mel Gorman
2021-06-15 20:42 ` Peter Zijlstra
2021-06-15 21:13 ` Phil Auld [this message]
2021-06-16 9:03 ` Mel Gorman
2021-06-17 15:01 ` Phil Auld
2021-06-17 15:40 ` Mel Gorman
2021-06-18 19:22 ` Phil Auld
2021-06-16 15:52 ` Vincent Guittot
2021-06-17 7:44 ` Mel Gorman
2021-06-17 8:30 ` Vincent Guittot
2021-06-17 9:40 ` Mel Gorman
2021-06-17 10:02 ` Vincent Guittot
2021-06-17 11:05 ` Mel Gorman
2021-06-17 15:03 ` Vincent Guittot
2021-06-17 15:47 ` Mel Gorman
2021-06-17 16:05 ` Vincent Guittot
2021-06-18 8:46 ` [tip: sched/core] " tip-bot2 for Peter Zijlstra
2021-06-23 14:46 ` [sched/fair] 5359f5ca0f: phoronix-test-suite.stress-ng.SystemVMessagePassing.bogo_ops_s 77.9% improvement kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMkX+MMVV0aMjmR8@lorien.usersys.redhat.com \
--to=pauld@redhat.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@techsingularity.net \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=valentin.schneider@arm.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).