From: Peter Zijlstra <peterz@infradead.org>
To: Frederic Weisbecker <frederic@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
"Eric W . Biederman" <ebiederm@xmission.com>,
Oleg Nesterov <oleg@redhat.com>, Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH 2/6] posix-cpu-timers: Don't start process wide cputime counter if timer is disabled
Date: Wed, 16 Jun 2021 10:51:21 +0200 [thread overview]
Message-ID: <YMm7iafJ1mberGIg@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20210604113159.26177-3-frederic@kernel.org>
On Fri, Jun 04, 2021 at 01:31:55PM +0200, Frederic Weisbecker wrote:
> If timer_settime() is called with a 0 expiration on a timer that is
> already disabled, the process wide cputime counter will be started
> and won't ever get a chance to be stopped by stop_process_timer() since
> no timer is actually armed to be processed.
>
> This process wide counter might bring some performance hit due to the
> concurrent atomic additions at the thread group scope.
>
> The following snippet is enough to trigger the issue.
>
> void trigger_process_counter(void)
> {
> timer_t id;
> struct itimerspec val = { };
>
> timer_create(CLOCK_PROCESS_CPUTIME_ID, NULL, &id);
> timer_settime(id, TIMER_ABSTIME, &val, NULL);
> timer_delete(id);
> }
>
> So make sure we don't needlessly start it.
>
> Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
> Cc: Oleg Nesterov <oleg@redhat.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Peter Zijlstra (Intel) <peterz@infradead.org>
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: Eric W. Biederman <ebiederm@xmission.com>
> ---
> kernel/time/posix-cpu-timers.c | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/time/posix-cpu-timers.c b/kernel/time/posix-cpu-timers.c
> index aa52fc85dbcb..132fd56fb1cd 100644
> --- a/kernel/time/posix-cpu-timers.c
> +++ b/kernel/time/posix-cpu-timers.c
> @@ -632,10 +632,15 @@ static int posix_cpu_timer_set(struct k_itimer *timer, int timer_flags,
> * times (in arm_timer). With an absolute time, we must
> * check if it's already passed. In short, we need a sample.
> */
> - if (CPUCLOCK_PERTHREAD(timer->it_clock))
> + if (CPUCLOCK_PERTHREAD(timer->it_clock)) {
> val = cpu_clock_sample(clkid, p);
> - else
> - val = cpu_clock_sample_group(clkid, p, true);
> + } else {
> + /*
> + * Sample group but only start the process wide cputime counter
> + * if the timer is to be enabled.
> + */
> + val = cpu_clock_sample_group(clkid, p, !!new_expires);
> + }
The cpu_timer_enqueue() is in arm_timer() and the condition for calling
that is:
'new_expires != 0 && val < new_expires'
Which is not the same as the one you add.
I'm thinking the fundamental problem here is the disconnect between
cpu_timer_enqueue() and pct->timers_active ?
next prev parent reply other threads:[~2021-06-16 8:51 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-04 11:31 [PATCH 0/6] posix-cpu-timers: Bunch of fixes Frederic Weisbecker
2021-06-04 11:31 ` [PATCH 1/6] posix-cpu-timers: Fix rearm racing against process tick Frederic Weisbecker
2021-06-09 11:54 ` Frederic Weisbecker
2021-06-11 11:49 ` Peter Zijlstra
2021-06-11 12:37 ` Frederic Weisbecker
2021-06-04 11:31 ` [PATCH 2/6] posix-cpu-timers: Don't start process wide cputime counter if timer is disabled Frederic Weisbecker
2021-06-09 12:18 ` Frederic Weisbecker
2021-06-10 10:24 ` Frederic Weisbecker
2021-06-16 8:51 ` Peter Zijlstra [this message]
2021-06-16 10:51 ` Frederic Weisbecker
2021-06-16 11:26 ` Peter Zijlstra
2021-06-16 11:50 ` Peter Zijlstra
2021-06-04 11:31 ` [PATCH 3/6] posix-cpu-timers: Force next_expiration recalc after timer deletion Frederic Weisbecker
2021-06-16 9:16 ` Peter Zijlstra
2021-06-04 11:31 ` [PATCH 4/6] posix-cpu-timers: Force next_expiration recalc after timer reset Frederic Weisbecker
2021-06-16 9:23 ` Peter Zijlstra
2021-06-16 11:21 ` Frederic Weisbecker
2021-06-16 11:33 ` Peter Zijlstra
2021-06-04 11:31 ` [PATCH 5/6] posix-cpu-timers: Force next expiration recalc after early timer firing Frederic Weisbecker
2021-06-16 9:42 ` Peter Zijlstra
2021-06-16 11:59 ` Frederic Weisbecker
2021-06-16 13:23 ` Peter Zijlstra
2021-06-16 14:53 ` Frederic Weisbecker
2021-06-04 11:31 ` [PATCH 6/6] posix-cpu-timers: Force next expiration recalc after itimer reset Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMm7iafJ1mberGIg@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=ebiederm@xmission.com \
--cc=frederic@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).