From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E255C48BE5 for ; Wed, 16 Jun 2021 08:08:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2FB1B61159 for ; Wed, 16 Jun 2021 08:08:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232009AbhFPIKk (ORCPT ); Wed, 16 Jun 2021 04:10:40 -0400 Received: from mga03.intel.com ([134.134.136.65]:47710 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231381AbhFPIKe (ORCPT ); Wed, 16 Jun 2021 04:10:34 -0400 IronPort-SDR: IpRYbzz6g9SanLWvp+yfqGivir7Hilu58BmW2mD0voM2N2IWF9evIApMaqxqvoYvZZd1S3uE0j Zh7VWGkbpsfg== X-IronPort-AV: E=McAfee;i="6200,9189,10016"; a="206172017" X-IronPort-AV: E=Sophos;i="5.83,277,1616482800"; d="scan'208";a="206172017" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jun 2021 01:08:25 -0700 IronPort-SDR: zJ/1OX5EmUkqVqzyhny2w0M+m76INvVXrFHm0Zu38LlODpJuiyF2h2TIr5+KNpew2bgr1ReUfX 4n/j6ru8u8Vw== X-IronPort-AV: E=Sophos;i="5.83,277,1616482800"; d="scan'208";a="621613886" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jun 2021 01:08:22 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1ltQaw-002lFR-FG; Wed, 16 Jun 2021 11:08:18 +0300 Date: Wed, 16 Jun 2021 11:08:18 +0300 From: Andy Shevchenko To: Randy Dunlap Cc: Chris Down , Linux Kernel Mailing List , Petr Mladek , Jessica Yu , Sergey Senozhatsky , John Ogness , Steven Rostedt , Greg Kroah-Hartman , Johannes Weiner , Kees Cook , Rasmus Villemoes , kernel-team@fb.com Subject: Re: [PATCH v7 1/5] string_helpers: Escape double quotes in escape_special Message-ID: References: <796701ff-18f9-a637-fca4-808ae36b336f@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <796701ff-18f9-a637-fca4-808ae36b336f@infradead.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 15, 2021 at 07:05:25PM -0700, Randy Dunlap wrote: > On 6/15/21 5:00 PM, Chris Down wrote: > > Andy Shevchenko writes: > >>> I've checked uses of ESCAPE_SPECIAL and %pE across the codebase, and I'm > >> > >> checked the uses > > > > Hmm, what's wrong with using the zero article for "checked uses"? I mean, I don't have any strong resistance, but I don't see anything wrong with it either, and it matches how I'd naturally speak. > > > > Agreed on the others, though, hopefully they can be massaged in :-) > > Ack, I don't see anything wrong with it either. I guess you know better than me :-) I'm just a mere non-native speaker here to whom it's stylistically harder to parse without the article. -- With Best Regards, Andy Shevchenko