* ALSA: usb-audio: Fix rate on Ozone Z90 USB headset
[not found] <CGME20210616091516epcas2p2111c9b941d0e60fb0a6ae9646fb80d26@epcas2p2.samsung.com>
@ 2021-06-16 9:01 ` Daehwan Jung
2021-06-16 9:30 ` Greg Kroah-Hartman
0 siblings, 1 reply; 5+ messages in thread
From: Daehwan Jung @ 2021-06-16 9:01 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Daehwan Jung, Jaroslav Kysela, Takashi Iwai, Lukasz Halman,
Johan Hovold, alsa-devel, linux-kernel
It mislabels its 96 kHz altsetting and that's why it causes some noise
Signed-off-by: Daehwan Jung <dh10.jung@samsung.com>
---
sound/usb/format.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/usb/format.c b/sound/usb/format.c
index 2287f8c..eb216fe 100644
--- a/sound/usb/format.c
+++ b/sound/usb/format.c
@@ -223,9 +223,11 @@ static int parse_audio_format_rates_v1(struct snd_usb_audio *chip, struct audiof
continue;
/* C-Media CM6501 mislabels its 96 kHz altsetting */
/* Terratec Aureon 7.1 USB C-Media 6206, too */
+ /* Ozone Z90 USB C-Media, too */
if (rate == 48000 && nr_rates == 1 &&
(chip->usb_id == USB_ID(0x0d8c, 0x0201) ||
chip->usb_id == USB_ID(0x0d8c, 0x0102) ||
+ chip->usb_id == USB_ID(0x0d8c, 0x0078) ||
chip->usb_id == USB_ID(0x0ccd, 0x00b1)) &&
fp->altsetting == 5 && fp->maxpacksize == 392)
rate = 96000;
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: ALSA: usb-audio: Fix rate on Ozone Z90 USB headset
2021-06-16 9:01 ` ALSA: usb-audio: Fix rate on Ozone Z90 USB headset Daehwan Jung
@ 2021-06-16 9:30 ` Greg Kroah-Hartman
0 siblings, 0 replies; 5+ messages in thread
From: Greg Kroah-Hartman @ 2021-06-16 9:30 UTC (permalink / raw)
To: Daehwan Jung
Cc: Jaroslav Kysela, Takashi Iwai, Lukasz Halman, Johan Hovold,
alsa-devel, linux-kernel
On Wed, Jun 16, 2021 at 06:01:01PM +0900, Daehwan Jung wrote:
> It mislabels its 96 kHz altsetting and that's why it causes some noise
>
> Signed-off-by: Daehwan Jung <dh10.jung@samsung.com>
> ---
> sound/usb/format.c | 2 ++
> 1 file changed, 2 insertions(+)
I am not the sound/usb/ maintainer, so I do not know why you sent this
"To:" me.
Also, can you resend and add a cc: stable to the signed-off-by: area to
let this get backported properly?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: ALSA: usb-audio: fix rate on Ozone Z90 USB headset
2021-06-16 9:34 ` ALSA: usb-audio: fix " Daehwan Jung
2021-06-16 10:30 ` Greg Kroah-Hartman
@ 2021-06-17 9:39 ` Takashi Iwai
1 sibling, 0 replies; 5+ messages in thread
From: Takashi Iwai @ 2021-06-17 9:39 UTC (permalink / raw)
To: Daehwan Jung
Cc: Jaroslav Kysela, Takashi Iwai, Greg Kroah-Hartman, Johan Hovold,
Lukasz Halman, alsa-devel, linux-kernel
On Wed, 16 Jun 2021 11:34:55 +0200,
Daehwan Jung wrote:
>
> It mislabels its 96 kHz altsetting and that's why it causes some noise
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Daehwan Jung <dh10.jung@samsung.com>
Applied now. Thanks.
Takashi
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: ALSA: usb-audio: fix rate on Ozone Z90 USB headset
2021-06-16 9:34 ` ALSA: usb-audio: fix " Daehwan Jung
@ 2021-06-16 10:30 ` Greg Kroah-Hartman
2021-06-17 9:39 ` Takashi Iwai
1 sibling, 0 replies; 5+ messages in thread
From: Greg Kroah-Hartman @ 2021-06-16 10:30 UTC (permalink / raw)
To: Daehwan Jung
Cc: Jaroslav Kysela, Takashi Iwai, Johan Hovold, Lukasz Halman,
alsa-devel, linux-kernel
On Wed, Jun 16, 2021 at 06:34:55PM +0900, Daehwan Jung wrote:
> It mislabels its 96 kHz altsetting and that's why it causes some noise
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
I don't care about this. But the stable tree probably does, please
read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* ALSA: usb-audio: fix rate on Ozone Z90 USB headset
[not found] <CGME20210616094912epcas2p38028df32b89b7cc79ba16c0215f8f664@epcas2p3.samsung.com>
@ 2021-06-16 9:34 ` Daehwan Jung
2021-06-16 10:30 ` Greg Kroah-Hartman
2021-06-17 9:39 ` Takashi Iwai
0 siblings, 2 replies; 5+ messages in thread
From: Daehwan Jung @ 2021-06-16 9:34 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai
Cc: Daehwan Jung, Greg Kroah-Hartman, Johan Hovold, Lukasz Halman,
alsa-devel, linux-kernel
It mislabels its 96 kHz altsetting and that's why it causes some noise
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Daehwan Jung <dh10.jung@samsung.com>
---
sound/usb/format.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/usb/format.c b/sound/usb/format.c
index 2287f8c..eb216fe 100644
--- a/sound/usb/format.c
+++ b/sound/usb/format.c
@@ -223,9 +223,11 @@ static int parse_audio_format_rates_v1(struct snd_usb_audio *chip, struct audiof
continue;
/* C-Media CM6501 mislabels its 96 kHz altsetting */
/* Terratec Aureon 7.1 USB C-Media 6206, too */
+ /* Ozone Z90 USB C-Media, too */
if (rate == 48000 && nr_rates == 1 &&
(chip->usb_id == USB_ID(0x0d8c, 0x0201) ||
chip->usb_id == USB_ID(0x0d8c, 0x0102) ||
+ chip->usb_id == USB_ID(0x0d8c, 0x0078) ||
chip->usb_id == USB_ID(0x0ccd, 0x00b1)) &&
fp->altsetting == 5 && fp->maxpacksize == 392)
rate = 96000;
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-06-17 9:39 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20210616091516epcas2p2111c9b941d0e60fb0a6ae9646fb80d26@epcas2p2.samsung.com>
2021-06-16 9:01 ` ALSA: usb-audio: Fix rate on Ozone Z90 USB headset Daehwan Jung
2021-06-16 9:30 ` Greg Kroah-Hartman
[not found] <CGME20210616094912epcas2p38028df32b89b7cc79ba16c0215f8f664@epcas2p3.samsung.com>
2021-06-16 9:34 ` ALSA: usb-audio: fix " Daehwan Jung
2021-06-16 10:30 ` Greg Kroah-Hartman
2021-06-17 9:39 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).