From: Hangbin Liu <liuhangbin@gmail.com>
To: Chengyang Fan <cy.fan@huawei.com>
Cc: davem@davemloft.net, yoshfuji@linux-ipv6.org, dsahern@kernel.org,
kuba@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ipv4: fix memory leak in ip_mc_add1_src
Date: Wed, 16 Jun 2021 19:52:04 +0800 [thread overview]
Message-ID: <YMnl5C/jhqpQSmvQ@fedora> (raw)
In-Reply-To: <20210616095925.1571600-1-cy.fan@huawei.com>
On Wed, Jun 16, 2021 at 05:59:25PM +0800, Chengyang Fan wrote:
> BUG: memory leak
> unreferenced object 0xffff888101bc4c00 (size 32):
> comm "syz-executor527", pid 360, jiffies 4294807421 (age 19.329s)
> hex dump (first 32 bytes):
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> 01 00 00 00 00 00 00 00 ac 14 14 bb 00 00 02 00 ................
> backtrace:
> [<00000000f17c5244>] kmalloc include/linux/slab.h:558 [inline]
> [<00000000f17c5244>] kzalloc include/linux/slab.h:688 [inline]
> [<00000000f17c5244>] ip_mc_add1_src net/ipv4/igmp.c:1971 [inline]
> [<00000000f17c5244>] ip_mc_add_src+0x95f/0xdb0 net/ipv4/igmp.c:2095
> [<000000001cb99709>] ip_mc_source+0x84c/0xea0 net/ipv4/igmp.c:2416
> [<0000000052cf19ed>] do_ip_setsockopt net/ipv4/ip_sockglue.c:1294 [inline]
> [<0000000052cf19ed>] ip_setsockopt+0x114b/0x30c0 net/ipv4/ip_sockglue.c:1423
> [<00000000477edfbc>] raw_setsockopt+0x13d/0x170 net/ipv4/raw.c:857
> [<00000000e75ca9bb>] __sys_setsockopt+0x158/0x270 net/socket.c:2117
> [<00000000bdb993a8>] __do_sys_setsockopt net/socket.c:2128 [inline]
> [<00000000bdb993a8>] __se_sys_setsockopt net/socket.c:2125 [inline]
> [<00000000bdb993a8>] __x64_sys_setsockopt+0xba/0x150 net/socket.c:2125
> [<000000006a1ffdbd>] do_syscall_64+0x40/0x80 arch/x86/entry/common.c:47
> [<00000000b11467c4>] entry_SYSCALL_64_after_hwframe+0x44/0xae
>
> In commit 24803f38a5c0 ("igmp: do not remove igmp souce list info when set
> link down"), the ip_mc_clear_src() in ip_mc_destroy_dev() was removed,
> because it was also called in igmpv3_clear_delrec().
>
> Rough callgraph:
>
> inetdev_destroy
> -> ip_mc_destroy_dev
> -> igmpv3_clear_delrec
> -> ip_mc_clear_src
> -> RCU_INIT_POINTER(dev->ip_ptr, NULL)
>
> However, ip_mc_clear_src() called in igmpv3_clear_delrec() doesn't
> release in_dev->mc_list->sources. And RCU_INIT_POINTER() assigns the
> NULL to dev->ip_ptr. As a result, in_dev cannot be obtained through
> inetdev_by_index() and then in_dev->mc_list->sources cannot be released
> by ip_mc_del1_src() in the sock_close. Rough call sequence goes like:
>
> sock_close
> -> __sock_release
> -> inet_release
> -> ip_mc_drop_socket
> -> inetdev_by_index
> -> ip_mc_leave_src
> -> ip_mc_del_src
> -> ip_mc_del1_src
>
> So we still need to call ip_mc_clear_src() in ip_mc_destroy_dev() to free
> in_dev->mc_list->sources.
>
> Fixes: 24803f38a5c0 ("igmp: do not remove igmp souce list info ...")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Chengyang Fan <cy.fan@huawei.com>
> ---
> net/ipv4/igmp.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/ipv4/igmp.c b/net/ipv4/igmp.c
> index 7b272bbed2b4..6b3c558a4f23 100644
> --- a/net/ipv4/igmp.c
> +++ b/net/ipv4/igmp.c
> @@ -1801,6 +1801,7 @@ void ip_mc_destroy_dev(struct in_device *in_dev)
> while ((i = rtnl_dereference(in_dev->mc_list)) != NULL) {
> in_dev->mc_list = i->next_rcu;
> in_dev->mc_count--;
> + ip_mc_clear_src(i);
> ip_ma_put(i);
> }
> }
> --
> 2.18.0.huawei.25
>
Acked-by: Hangbin Liu <liuhangbin@gmail.com>
next prev parent reply other threads:[~2021-06-16 11:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 9:59 [PATCH] net: ipv4: fix memory leak in ip_mc_add1_src Chengyang Fan
2021-06-16 11:52 ` Hangbin Liu [this message]
2021-06-16 19:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMnl5C/jhqpQSmvQ@fedora \
--to=liuhangbin@gmail.com \
--cc=cy.fan@huawei.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).