From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22496C48BE8 for ; Wed, 16 Jun 2021 16:20:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0F0AD61159 for ; Wed, 16 Jun 2021 16:20:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235129AbhFPQWY (ORCPT ); Wed, 16 Jun 2021 12:22:24 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:40874 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229503AbhFPQWW (ORCPT ); Wed, 16 Jun 2021 12:22:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=vSj9Cw2sZFxnc9sBK2ngjmm4yp0EI6eDCnwHta6M3PY=; b=dN1d0OagilH+uvDgQKP38uz0wk /VkYnzhrn/4sLpCWNIK8qF53+lspPV0cME3/45rNmH1x0KuXITIvZ54jIbA3i0f4bC1miLaduZdCt 1EgEJRewLEYuDcQC7/H7ZetOFAFmBgoZwPAk8myCPjb2ekJzMULjNyMDecLxhViupXRU=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1ltYGt-009knE-3W; Wed, 16 Jun 2021 18:20:07 +0200 Date: Wed, 16 Jun 2021 18:20:07 +0200 From: Andrew Lunn To: Guangbin Huang Cc: davem@davemloft.net, kuba@kernel.org, xie.he.0141@gmail.com, ms@dev.tdt.de, willemb@google.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, lipeng321@huawei.com Subject: Re: [PATCH net-next 5/8] net: hdlc_ppp: fix the comments style issue Message-ID: References: <1623836037-26812-1-git-send-email-huangguangbin2@huawei.com> <1623836037-26812-6-git-send-email-huangguangbin2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1623836037-26812-6-git-send-email-huangguangbin2@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > static int cp_table[EVENTS][STATES] = { > /* CLOSED STOPPED STOPPING REQ_SENT ACK_RECV ACK_SENT OPENED > - 0 1 2 3 4 5 6 */ > + * 0 1 2 3 4 5 6 > + */ > {IRC|SCR|3, INV , INV , INV , INV , INV , INV }, /* START */ > { INV , 0 , 0 , 0 , 0 , 0 , 0 }, /* STOP */ > { INV , INV ,STR|2, SCR|3 ,SCR|3, SCR|5 , INV }, /* TO+ */ This probably reduces the readability of the code. So i would not make this change. Please remember these are only guidelines. Please don't blindly make changes, or change it because some bot says so. Check that it actually makes sense and the code is better afterwards. Andrew