From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FCF8C48BE5 for ; Thu, 17 Jun 2021 07:57:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3883261166 for ; Thu, 17 Jun 2021 07:57:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230217AbhFQH7M (ORCPT ); Thu, 17 Jun 2021 03:59:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229712AbhFQH7L (ORCPT ); Thu, 17 Jun 2021 03:59:11 -0400 Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0956C061574 for ; Thu, 17 Jun 2021 00:57:03 -0700 (PDT) Received: by mail-pl1-x634.google.com with SMTP id e1so2483746plh.8 for ; Thu, 17 Jun 2021 00:57:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=lWxUJxhz7O6kFGlQehJLdP1IrX0/F+zia2bYyRaN+u4=; b=U7ji2Myu1pVJ0NTa6ROs3kMnITp4KGNBkxCIUDH/9h9v8zv3cIxcdfbXFH5UOTNtTu OH+k8UmW6BiKCCkAQ6iwnpson24WDcJQmLJ46T3wMSoGTEI9HpvoWWrzSEdpK7c9FnFR gNYx50mOrCUmNGwx4rBzgvwSJzMeMVlxpVp2w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=lWxUJxhz7O6kFGlQehJLdP1IrX0/F+zia2bYyRaN+u4=; b=EpeE8JiRih6U6bxaMe5m/sjEdKZZk25zpnjNc0q0hDn93RJp9/3D0oYQC0tg6DCDE7 TqXj1YF1ZPdO1DEFc4D6EX4tyMFQ0PrqQWjBavry3UoUrgR4RcNvy26OkF9RfwSQHwYv Mrp4Wy3MgdFL8CyLZPX7zrXAZ7HRnheFR6hNNrzq/abwFlQuREB/PBM6BbqVpNSoS0FY opVv/CYcs7xaLYdHVXaozM/9YaJFK6RnhKuKt/ruxB5XC+RdppyvvOgcDJdAbOm0gN6U 5m4LP0uKJHtb6U4C+JWXBBUJ80XcdLrtrLttI74/Rw8J7I3dpySYSsWTvrPBwlG9Px0L mAyw== X-Gm-Message-State: AOAM532/mbGy7ueZPxuxzmwDtZaP8rgzTN8DspFDG1JFaoUNQj2+dDXX h+y76uBQJHdY7gM7DvRmL4OoGw== X-Google-Smtp-Source: ABdhPJy+OzFqYL0+fgg7K7cexyu5dzwva4aO42WBStaKuByOyAyQ8YSjALACLshN7vsa2OBjnCUYWQ== X-Received: by 2002:a17:902:7590:b029:11c:432f:d1ec with SMTP id j16-20020a1709027590b029011c432fd1ecmr3351376pll.59.1623916623323; Thu, 17 Jun 2021 00:57:03 -0700 (PDT) Received: from google.com ([2409:10:2e40:5100:32ae:4292:bec1:e4]) by smtp.gmail.com with ESMTPSA id x6sm4253222pfd.173.2021.06.17.00.57.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Jun 2021 00:57:02 -0700 (PDT) Date: Thu, 17 Jun 2021 16:56:58 +0900 From: Sergey Senozhatsky To: Hans Verkuil Cc: Sergey Senozhatsky , Tomasz Figa , Ricardo Ribalda , Christoph Hellwig , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv2 8/8] videobuf2: handle non-contiguous DMA allocations Message-ID: References: <20210427131344.139443-1-senozhatsky@chromium.org> <20210427131344.139443-9-senozhatsky@chromium.org> <10a0903a-e295-5cba-683a-1eb89a0804ed@xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <10a0903a-e295-5cba-683a-1eb89a0804ed@xs4all.nl> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (21/06/03 13:59), Hans Verkuil wrote: > > > > +static void __vb2_dc_put(struct vb2_dc_buf *buf) > > +{ > > + if (buf->coherent_mem) { > > + dma_free_attrs(buf->dev, buf->size, buf->cookie, > > + buf->dma_addr, buf->attrs); > > + return; > > + } > > + > > + if (buf->vaddr) > > + dma_vunmap_noncontiguous(buf->dev, buf->vaddr); > > + dma_free_noncontiguous(buf->dev, buf->size, > > + buf->dma_sgt, buf->dma_addr); > > +} > > Is there a reason for creating __vb2_dc_put()? I found it more > a hindrance when reviewing than an advantage. I prefer to have > it moved to vb2_dc_put, that way all the clean up happens in that > single function. Done.