From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACEC0C2B9F4 for ; Thu, 17 Jun 2021 10:56:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 84BE9613CA for ; Thu, 17 Jun 2021 10:56:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232149AbhFQK6M (ORCPT ); Thu, 17 Jun 2021 06:58:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:48816 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231279AbhFQK6K (ORCPT ); Thu, 17 Jun 2021 06:58:10 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id B68DC613C1; Thu, 17 Jun 2021 10:56:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1623927362; bh=tdtJ3TT/sqXmbyHuuhhGQQmcFtIXnLuVyXiZ92I+b1A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TOgSWk1aEC0FOleq1QCmMEph695+5XbKRHOTuBB3YcU6uviGtcTm1e88KvVcmKypr aNwAZpfxwEJNKD47tYX7oymBW4lxvNzZz3BiocUt+v6xiFaDI7VnB7G+y2MFOT/KYE W8JD4WOEt+X8EMPnHgSVKca+v1QogvaGrCQaqgoY= Date: Thu, 17 Jun 2021 12:55:59 +0200 From: Greg KH To: Barry Song Cc: andriy.shevchenko@linux.intel.com, linux-kernel@vger.kernel.org, linux@rasmusvillemoes.dk, rafael@kernel.org, akpm@linux-foundation.org, rdunlap@infradead.org, agordeev@linux.ibm.com, sbrivio@redhat.com, jianpeng.ma@intel.com, yury.norov@gmail.com, valentin.schneider@arm.com, peterz@infradead.org, bristot@redhat.com, guodong.xu@linaro.org, tangchengchang@huawei.com, prime.zeng@hisilicon.com, yangyicong@huawei.com, tim.c.chen@linux.intel.com, tiantao6@hisilicon.com, Jonathan.Cameron@huawei.com, linuxarm@huawei.com Subject: Re: [PATCH v4 2/4] topology: use bin_attribute to avoid buff overflow Message-ID: References: <20210617101910.13228-1-song.bao.hua@hisilicon.com> <20210617101910.13228-3-song.bao.hua@hisilicon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210617101910.13228-3-song.bao.hua@hisilicon.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 17, 2021 at 10:19:08PM +1200, Barry Song wrote: > From: Tian Tao > > Reading sys/devices/system/cpu/cpuX/topology/ returns cpu topology. > However, the size of this file is limited to PAGE_SIZE because of the > limitation for sysfs attribute. so we use bin_attribute instead of > attribute to avoid NR_CPUS too big to cause buff overflow. > > Link: https://lore.kernel.org/lkml/20210319041618.14316-2-song.bao.hua@hisilicon.com/ > Signed-off-by: Tian Tao > Reviewed-by: Jonathan Cameron > Cc: Greg Kroah-Hartman > Cc: "Rafael J. Wysocki" As with the other patch, you have to also sign off on this as well. The link is pointing to a v5 of a different patch series, why put that here? thanks, greg k-h