* [PATCH] locking/lockdep: correct the description error for check_redundant()
@ 2021-06-17 15:05 Xiongwei Song
2021-06-17 15:17 ` Boqun Feng
0 siblings, 1 reply; 5+ messages in thread
From: Xiongwei Song @ 2021-06-17 15:05 UTC (permalink / raw)
To: peterz, mingo, will, longman, boqun.feng; +Cc: linux-kernel, Xiongwei Song
From: Xiongwei Song <sxwjean@gmail.com>
If there is no matched result, check_redundant() will return BFS_RNOMATCH.
Signed-off-by: Xiongwei Song <sxwjean@gmail.com>
---
kernel/locking/lockdep.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c
index cfe0f4374594..1f126ca7fbd7 100644
--- a/kernel/locking/lockdep.c
+++ b/kernel/locking/lockdep.c
@@ -2726,7 +2726,7 @@ static inline bool usage_skip(struct lock_list *entry, void *mask)
* <target> or not. If it can, <src> -> <target> dependency is already
* in the graph.
*
- * Return BFS_RMATCH if it does, or BFS_RMATCH if it does not, return BFS_E* if
+ * Return BFS_RMATCH if it does, or BFS_RNOMATCH if it does not, return BFS_E* if
* any error appears in the bfs search.
*/
static noinline enum bfs_result
--
2.30.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] locking/lockdep: correct the description error for check_redundant()
2021-06-17 15:05 [PATCH] locking/lockdep: correct the description error for check_redundant() Xiongwei Song
@ 2021-06-17 15:17 ` Boqun Feng
2021-06-18 1:50 ` Xiongwei Song
0 siblings, 1 reply; 5+ messages in thread
From: Boqun Feng @ 2021-06-17 15:17 UTC (permalink / raw)
To: Xiongwei Song; +Cc: peterz, mingo, will, longman, linux-kernel, Xiongwei Song
On Thu, Jun 17, 2021 at 11:05:23PM +0800, Xiongwei Song wrote:
> From: Xiongwei Song <sxwjean@gmail.com>
>
> If there is no matched result, check_redundant() will return BFS_RNOMATCH.
>
> Signed-off-by: Xiongwei Song <sxwjean@gmail.com>
Good catch!
Nit: you may want to capitalize the first letter after subsystem tag in
the patch title, like:
"locking/lockdep: Correct ..."
Reviewed-by: Boqun Feng <boqun.feng@gmail.com>
Regards,
Boqun
> ---
> kernel/locking/lockdep.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c
> index cfe0f4374594..1f126ca7fbd7 100644
> --- a/kernel/locking/lockdep.c
> +++ b/kernel/locking/lockdep.c
> @@ -2726,7 +2726,7 @@ static inline bool usage_skip(struct lock_list *entry, void *mask)
> * <target> or not. If it can, <src> -> <target> dependency is already
> * in the graph.
> *
> - * Return BFS_RMATCH if it does, or BFS_RMATCH if it does not, return BFS_E* if
> + * Return BFS_RMATCH if it does, or BFS_RNOMATCH if it does not, return BFS_E* if
> * any error appears in the bfs search.
> */
> static noinline enum bfs_result
> --
> 2.30.2
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] locking/lockdep: correct the description error for check_redundant()
2021-06-17 15:17 ` Boqun Feng
@ 2021-06-18 1:50 ` Xiongwei Song
0 siblings, 0 replies; 5+ messages in thread
From: Xiongwei Song @ 2021-06-18 1:50 UTC (permalink / raw)
To: Boqun Feng
Cc: Xiongwei Song, peterz, mingo, will, longman, Linux Kernel Mailing List
On Thu, Jun 17, 2021 at 11:17 PM Boqun Feng <boqun.feng@gmail.com> wrote:
>
> On Thu, Jun 17, 2021 at 11:05:23PM +0800, Xiongwei Song wrote:
> > From: Xiongwei Song <sxwjean@gmail.com>
> >
> > If there is no matched result, check_redundant() will return BFS_RNOMATCH.
> >
> > Signed-off-by: Xiongwei Song <sxwjean@gmail.com>
>
> Good catch!
>
> Nit: you may want to capitalize the first letter after subsystem tag in
> the patch title, like:
>
> "locking/lockdep: Correct ..."
Ok. Will update the patch.
>
> Reviewed-by: Boqun Feng <boqun.feng@gmail.com>
Thank you.
Regards,
Xiongwei
>
> Regards,
> Boqun
>
> > ---
> > kernel/locking/lockdep.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c
> > index cfe0f4374594..1f126ca7fbd7 100644
> > --- a/kernel/locking/lockdep.c
> > +++ b/kernel/locking/lockdep.c
> > @@ -2726,7 +2726,7 @@ static inline bool usage_skip(struct lock_list *entry, void *mask)
> > * <target> or not. If it can, <src> -> <target> dependency is already
> > * in the graph.
> > *
> > - * Return BFS_RMATCH if it does, or BFS_RMATCH if it does not, return BFS_E* if
> > + * Return BFS_RMATCH if it does, or BFS_RNOMATCH if it does not, return BFS_E* if
> > * any error appears in the bfs search.
> > */
> > static noinline enum bfs_result
> > --
> > 2.30.2
> >
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] locking/lockdep: Correct the description error for check_redundant()
2021-06-18 13:02 [PATCH] locking/lockdep: Correct " Xiongwei Song
@ 2021-06-18 13:16 ` Xiongwei Song
0 siblings, 0 replies; 5+ messages in thread
From: Xiongwei Song @ 2021-06-18 13:16 UTC (permalink / raw)
To: Xiongwei Song
Cc: peterz, mingo, will, longman, Boqun Feng, Linux Kernel Mailing List
On Fri, Jun 18, 2021 at 9:02 PM Xiongwei Song <sxwjean@me.com> wrote:
>
> From: Xiongwei Song <sxwjean@gmail.com>
>
> If there is no matched result, check_redundant() will return BFS_RNOMATCH.
>
> Signed-off-by: Xiongwei Song <sxwjean@gmail.com>
> Reviewed-by: Boqun Feng <boqun.feng@gmail.com>
> ---
> kernel/locking/lockdep.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c
> index cfe0f4374594..1f126ca7fbd7 100644
> --- a/kernel/locking/lockdep.c
> +++ b/kernel/locking/lockdep.c
> @@ -2726,7 +2726,7 @@ static inline bool usage_skip(struct lock_list *entry, void *mask)
> * <target> or not. If it can, <src> -> <target> dependency is already
> * in the graph.
> *
> - * Return BFS_RMATCH if it does, or BFS_RMATCH if it does not, return BFS_E* if
> + * Return BFS_RMATCH if it does, or BFS_RNOMATCH if it does not, return BFS_E* if
> * any error appears in the bfs search.
> */
> static noinline enum bfs_result
Sorry I forgot to add version info, this is v2.
Regarding v1 please see https://lkml.org/lkml/2021/6/17/1156.
Regards,
Xiongwei
> --
> 2.30.2
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] locking/lockdep: Correct the description error for check_redundant()
@ 2021-06-18 13:02 Xiongwei Song
2021-06-18 13:16 ` Xiongwei Song
0 siblings, 1 reply; 5+ messages in thread
From: Xiongwei Song @ 2021-06-18 13:02 UTC (permalink / raw)
To: peterz, mingo, will, longman, boqun.feng; +Cc: linux-kernel, Xiongwei Song
From: Xiongwei Song <sxwjean@gmail.com>
If there is no matched result, check_redundant() will return BFS_RNOMATCH.
Signed-off-by: Xiongwei Song <sxwjean@gmail.com>
Reviewed-by: Boqun Feng <boqun.feng@gmail.com>
---
kernel/locking/lockdep.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c
index cfe0f4374594..1f126ca7fbd7 100644
--- a/kernel/locking/lockdep.c
+++ b/kernel/locking/lockdep.c
@@ -2726,7 +2726,7 @@ static inline bool usage_skip(struct lock_list *entry, void *mask)
* <target> or not. If it can, <src> -> <target> dependency is already
* in the graph.
*
- * Return BFS_RMATCH if it does, or BFS_RMATCH if it does not, return BFS_E* if
+ * Return BFS_RMATCH if it does, or BFS_RNOMATCH if it does not, return BFS_E* if
* any error appears in the bfs search.
*/
static noinline enum bfs_result
--
2.30.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-06-18 13:17 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-17 15:05 [PATCH] locking/lockdep: correct the description error for check_redundant() Xiongwei Song
2021-06-17 15:17 ` Boqun Feng
2021-06-18 1:50 ` Xiongwei Song
2021-06-18 13:02 [PATCH] locking/lockdep: Correct " Xiongwei Song
2021-06-18 13:16 ` Xiongwei Song
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).