linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Bhupesh Sharma <bhupesh.sharma@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, bhupesh.linux@gmail.com,
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, lgirdwood@gmail.com,
	Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v3 3/4] pinctrl: qcom/pinctrl-spmi-gpio: Arrange compatibles alphabetically
Date: Fri, 18 Jun 2021 13:02:18 -0500	[thread overview]
Message-ID: <YMzfqm+xKno7YDzw@builder.lan> (raw)
In-Reply-To: <20210617053432.350486-4-bhupesh.sharma@linaro.org>

On Thu 17 Jun 00:34 CDT 2021, Bhupesh Sharma wrote:

> Arrange the compatibles inside qcom pinctrl-spmi gpio driver
> alphabetically.
> 

Nice, thanks Bhupesh.

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

Regards,
Bjorn

> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
> ---
>  drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 32 ++++++++++++------------
>  1 file changed, 16 insertions(+), 16 deletions(-)
> 
> diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> index 00870da0c94e..89f6147efe58 100644
> --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> @@ -1104,23 +1104,14 @@ static int pmic_gpio_remove(struct platform_device *pdev)
>  }
>  
>  static const struct of_device_id pmic_gpio_of_match[] = {
> -	{ .compatible = "qcom,pm8005-gpio", .data = (void *) 4 },
> -	{ .compatible = "qcom,pm8916-gpio", .data = (void *) 4 },
> -	{ .compatible = "qcom,pm8941-gpio", .data = (void *) 36 },
> -	/* pm8950 has 8 GPIOs with holes on 3 */
> -	{ .compatible = "qcom,pm8950-gpio", .data = (void *) 8 },
> -	{ .compatible = "qcom,pmi8950-gpio", .data = (void *) 2 },
> -	{ .compatible = "qcom,pm8994-gpio", .data = (void *) 22 },
> -	{ .compatible = "qcom,pmi8994-gpio", .data = (void *) 10 },
> -	{ .compatible = "qcom,pm8998-gpio", .data = (void *) 26 },
> -	{ .compatible = "qcom,pmi8998-gpio", .data = (void *) 14 },
> -	{ .compatible = "qcom,pma8084-gpio", .data = (void *) 22 },
> -	/* pms405 has 12 GPIOs with holes on 1, 9, and 10 */
> -	{ .compatible = "qcom,pms405-gpio", .data = (void *) 12 },
>  	/* pm660 has 13 GPIOs with holes on 1, 5, 6, 7, 8 and 10 */
>  	{ .compatible = "qcom,pm660-gpio", .data = (void *) 13 },
>  	/* pm660l has 12 GPIOs with holes on 1, 2, 10, 11 and 12 */
>  	{ .compatible = "qcom,pm660l-gpio", .data = (void *) 12 },
> +	{ .compatible = "qcom,pm6150-gpio", .data = (void *) 10 },
> +	{ .compatible = "qcom,pm6150l-gpio", .data = (void *) 12 },
> +	{ .compatible = "qcom,pm8005-gpio", .data = (void *) 4 },
> +	{ .compatible = "qcom,pm8008-gpio", .data = (void *) 2 },
>  	/* pm8150 has 10 GPIOs with holes on 2, 5, 7 and 8 */
>  	{ .compatible = "qcom,pm8150-gpio", .data = (void *) 10 },
>  	/* pm8150b has 12 GPIOs with holes on 3, r and 7 */
> @@ -1130,12 +1121,21 @@ static const struct of_device_id pmic_gpio_of_match[] = {
>  	{ .compatible = "qcom,pm8350-gpio", .data = (void *) 10 },
>  	{ .compatible = "qcom,pm8350b-gpio", .data = (void *) 8 },
>  	{ .compatible = "qcom,pm8350c-gpio", .data = (void *) 9 },
> +	{ .compatible = "qcom,pm8916-gpio", .data = (void *) 4 },
> +	{ .compatible = "qcom,pm8941-gpio", .data = (void *) 36 },
> +	/* pm8950 has 8 GPIOs with holes on 3 */
> +	{ .compatible = "qcom,pm8950-gpio", .data = (void *) 8 },
> +	{ .compatible = "qcom,pm8994-gpio", .data = (void *) 22 },
> +	{ .compatible = "qcom,pm8998-gpio", .data = (void *) 26 },
> +	{ .compatible = "qcom,pma8084-gpio", .data = (void *) 22 },
> +	{ .compatible = "qcom,pmi8950-gpio", .data = (void *) 2 },
> +	{ .compatible = "qcom,pmi8994-gpio", .data = (void *) 10 },
> +	{ .compatible = "qcom,pmi8998-gpio", .data = (void *) 14 },
>  	{ .compatible = "qcom,pmk8350-gpio", .data = (void *) 4 },
>  	{ .compatible = "qcom,pmr735a-gpio", .data = (void *) 4 },
>  	{ .compatible = "qcom,pmr735b-gpio", .data = (void *) 4 },
> -	{ .compatible = "qcom,pm6150-gpio", .data = (void *) 10 },
> -	{ .compatible = "qcom,pm6150l-gpio", .data = (void *) 12 },
> -	{ .compatible = "qcom,pm8008-gpio", .data = (void *) 2 },
> +	/* pms405 has 12 GPIOs with holes on 1, 9, and 10 */
> +	{ .compatible = "qcom,pms405-gpio", .data = (void *) 12 },
>  	/* pmx55 has 11 GPIOs with holes on 3, 7, 10, 11 */
>  	{ .compatible = "qcom,pmx55-gpio", .data = (void *) 11 },
>  	{ },
> -- 
> 2.31.1
> 

  reply	other threads:[~2021-06-18 18:02 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-17  5:34 [PATCH v3 0/4] pinctrl: qcom/pinctrl-spmi-gpio: Add support for pmic-gpio on SA8155p-adp Bhupesh Sharma
2021-06-17  5:34 ` [PATCH v3 1/4] dt-bindings: pinctrl: qcom,pmic-gpio: Arrange compatibles alphabetically Bhupesh Sharma
2021-06-18 17:59   ` Bjorn Andersson
2021-06-24 21:24   ` Rob Herring
2021-06-25 23:51   ` Linus Walleij
2021-06-26 18:29     ` Bhupesh Sharma
2021-06-29 12:36       ` Bhupesh Sharma
2021-06-17  5:34 ` [PATCH v3 2/4] dt-bindings: pinctrl: qcom,pmic-gpio: Add compatible for SA8155p-adp Bhupesh Sharma
2021-06-18 18:00   ` Bjorn Andersson
2021-06-24 21:24   ` Rob Herring
2021-06-17  5:34 ` [PATCH v3 3/4] pinctrl: qcom/pinctrl-spmi-gpio: Arrange compatibles alphabetically Bhupesh Sharma
2021-06-18 18:02   ` Bjorn Andersson [this message]
2021-06-17  5:34 ` [PATCH v3 4/4] pinctrl: qcom/pinctrl-spmi-gpio: Add compatible for pmic-gpio on SA8155p-adp Bhupesh Sharma
2021-06-18 18:02   ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YMzfqm+xKno7YDzw@builder.lan \
    --to=bjorn.andersson@linaro.org \
    --cc=bhupesh.linux@gmail.com \
    --cc=bhupesh.sharma@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).