From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA63EC11F69 for ; Thu, 1 Jul 2021 18:15:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8D2E46141E for ; Thu, 1 Jul 2021 18:15:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233899AbhGASSQ (ORCPT ); Thu, 1 Jul 2021 14:18:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56038 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229844AbhGASSP (ORCPT ); Thu, 1 Jul 2021 14:18:15 -0400 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E0DFDC061762 for ; Thu, 1 Jul 2021 11:15:43 -0700 (PDT) Received: by mail-pj1-x1034.google.com with SMTP id l11so4757955pji.5 for ; Thu, 01 Jul 2021 11:15:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=VBK3elG7+RffbG0U9TL73XjsoLZSaxYTEj/YLeL64j4=; b=F4yNM9ndU/GFX5Dpx1BNEVZH7b9oSr88oWu0kz62oL9CJgaPBh/H+hgIGXunaN2WTt uZjvt5G1mUhUjVH9m6/v8w3WKGzo228LP2r6bRnqP4wZFsKZBWbbh1sjJYLEZgzPmMC4 XtkhmMyF6RaCmjzBMGycnZY0qoIFT8ePmVeaz1hSrUZgYtLrEZobquEFLKEodvtVpy5K ykSuAWf+OI0h/q2uGyQhhgQKVtRVvvTYcIy1142iiXk/mBQHJ3MCEFePfQ/YPt0RpBKy yDCa0L0EZlR9eoBxm06lh7Pn7kuMYlsMiP6M2ORVr6eZi2Bs3S+jcPRbHxiE9bPs9CBx VTYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=VBK3elG7+RffbG0U9TL73XjsoLZSaxYTEj/YLeL64j4=; b=LKrDwpvKkyhglXXO1rSl3bfdhCeKxASGBKLEI2ci8sY1XdOKeRI3rARUNXX0B8t5Mp HHKp9AFTzecnIIgpSOMpITJjncvZyltL5n/yVw+xaRW1YF8XiDV/C3h+qlodQoBkU3zn endbBQokg4jBRMLfDmvcvoicFB6ObbUB78IIOA48QNvD4z7ksOQlzCeXD5AzSWLmJrbb 5HkGFW1BpVmo5TGQS2yifI0DJt+xT+ryaa+h95PfClIqAg3uLNav/jt/k74kogGkFoMY ui7Io8d1j1RqF6xeLhN7zLVJ1ANQ29uU8/dpjQ9omJsQTMkQC/6WFwHYWtaisnpJVOmx SLng== X-Gm-Message-State: AOAM533bgdrFHix/WV+YCpHiG/oHNaObXFup1LKWc5pfAJy2Mu68hVZr 66aptzysVJKPZEyh7Hinamvt35qn4s3Dxg== X-Google-Smtp-Source: ABdhPJx+0AKjtxUAwtA0opUfMtTSNeImrLpUEBTW3u8J/HIZARu6V3+zpwFavk5Btxnje99bkW6jWQ== X-Received: by 2002:a17:90b:46c3:: with SMTP id jx3mr901300pjb.206.1625163343317; Thu, 01 Jul 2021 11:15:43 -0700 (PDT) Received: from google.com ([2620:15c:280:201:558a:406a:d453:dbe5]) by smtp.gmail.com with ESMTPSA id n23sm714011pff.93.2021.07.01.11.15.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Jul 2021 11:15:42 -0700 (PDT) Date: Thu, 1 Jul 2021 11:15:37 -0700 From: Paul Burton To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Joel Fernandes , stable@vger.kernel.org Subject: Re: [PATCH v2 2/2] tracing: Resize tgid_map to pid_max, not PID_MAX_DEFAULT Message-ID: References: <20210701095525.400839d3@oasis.local.home> <20210701172407.889626-1-paulburton@google.com> <20210701172407.889626-2-paulburton@google.com> <20210701141221.1d0b1fe0@oasis.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210701141221.1d0b1fe0@oasis.local.home> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Steven, On Thu, Jul 01, 2021 at 02:12:21PM -0400, Steven Rostedt wrote: > On Thu, 1 Jul 2021 10:24:07 -0700 > Paul Burton wrote: > > > +static int *trace_find_tgid_ptr(int pid) > > +{ > > + // Pairs with the smp_store_release in set_tracer_flag() to ensure that > > + // if we observe a non-NULL tgid_map then we also observe the correct > > + // tgid_map_max. > > BTW, it's against the Linux kernel coding style to use // for comments. > > I can take this patch, but I need to change this to: > > /* > * Pairs with the smp_store_release in set_tracer_flag() to ensure that > * if we observe a non-NULL tgid_map then we also observe the correct > * tgid_map_max. > */ > > Same with the other comments. Please follow coding style that can be > found in: > > Documentation/process/coding-style.rst > > And see section 8 on Commenting. Yeah, sorry about that - I should know better having been a maintainer in a former life... Just to confirm - are you happy to fix those up when applying or should I send a v3? Thanks, Paul