linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: "Stefan Brüns" <stefan.bruens@rwth-aachen.de>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Daniele Palmas" <dnlplm@gmail.com>, "Bjørn Mork" <bjorn@mork.no>
Subject: Re: [PATCH v2] USB: serial: qcserial: Support for SDX55 based Sierra Wireless 5G modules
Date: Fri, 2 Jul 2021 10:27:51 +0200	[thread overview]
Message-ID: <YN7OBzmcsidWIG0F@hovoldconsulting.com> (raw)
In-Reply-To: <3614092.7mX7SIBJgt@pebbles>

[-- Attachment #1: Type: text/plain, Size: 1572 bytes --]

On Thu, Jul 01, 2021 at 06:41:26PM +0200, Stefan Brüns wrote:
> On Donnerstag, 24. Juni 2021 09:28:59 CEST Johan Hovold wrote:
> > [ +CC: Daniele and Bjørn ]
> > 
> > On Fri, Jun 11, 2021 at 03:58:41PM +0200, Stefan Brüns wrote:
> > > The devices exposes two different interface compositions:
> > > - QDL mode, single interface
> > > - MBIM mode, MBIM class compliant plus AT/DM(/ADB)
> > > 
> > > Current firmware versions (up to 01.07.19) do not expose an NMEA port.
> > 
> > We already have at least one SDX55 based modem (FN980) supported by the
> > option driver. Any particular reason why you chose to add it to qcserial
> > instead of option?
> > 
> Support for qualcomm based modems are spread over option and qcserial. All 
> other Sierra devices are supported by qcserial.

Ok, but we may still end up adding this one to option if matching on the
interface protocol works.

> > Note that the FN980 also needs the ZLP flag set in QDL (flashing) mode,
> > I'd assume this one needs it too.
> 
> It depends if you implement the Firehose protocol in accordance to the 
> specification or not. 80-NG319-1 (Firehose specification) explicitly states to 
> pad any XML command packet which is an exact multiple of 512 bytes with an 
> extra newline or other whitespace character.

Thanks for the details. If you're referring to the device-side
implementation it seems a bit fragile to not just set the ZLP flag since
apparently there are some non-standard implementations out there. But
sure, we can do that later if needed.

Johan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

      reply	other threads:[~2021-07-02  8:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-11 13:45 [PATCH] Add support for SDX55 based Sierra Wireless 5G modules Stefan Brüns
2021-06-11 13:58 ` [PATCH v2] USB: serial: qcserial: Support " Stefan Brüns
2021-06-24  7:28   ` Johan Hovold
2021-06-24 11:15     ` Bjørn Mork
2021-07-01 16:28       ` Stefan Brüns
2021-07-02  7:32         ` Bjørn Mork
2021-07-01 16:41     ` Stefan Brüns
2021-07-02  8:27       ` Johan Hovold [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YN7OBzmcsidWIG0F@hovoldconsulting.com \
    --to=johan@kernel.org \
    --cc=bjorn@mork.no \
    --cc=dnlplm@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=stefan.bruens@rwth-aachen.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).