From: Leon Romanovsky <leon@kernel.org>
To: Nathan Chancellor <nathan@kernel.org>
Cc: Saeed Mahameed <saeedm@nvidia.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com
Subject: Re: [PATCH net-next] net/mlx5: Use cpumask_available() in mlx5_eq_create_generic()
Date: Mon, 21 Jun 2021 11:53:52 +0300 [thread overview]
Message-ID: <YNBToF0+eruEG7JL@unreal> (raw)
In-Reply-To: <20210618000358.2402567-1-nathan@kernel.org>
On Thu, Jun 17, 2021 at 05:03:59PM -0700, Nathan Chancellor wrote:
> When CONFIG_CPUMASK_OFFSTACK is unset, cpumask_var_t is not a pointer
> but a single element array, meaning its address in a structure cannot be
> NULL as long as it is not the first element, which it is not. This
> results in a clang warning:
>
> drivers/net/ethernet/mellanox/mlx5/core/eq.c:715:14: warning: address of
> array 'param->affinity' will always evaluate to 'true'
> [-Wpointer-bool-conversion]
> if (!param->affinity)
> ~~~~~~~~^~~~~~~~
> 1 warning generated.
>
> The helper cpumask_available was added in commit f7e30f01a9e2 ("cpumask:
> Add helper cpumask_available()") to handle situations like this so use
> it to keep the meaning of the code the same while resolving the warning.
>
> Fixes: e4e3f24b822f ("net/mlx5: Provide cpumask at EQ creation phase")
> Link: https://github.com/ClangBuiltLinux/linux/issues/1400
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/eq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
next prev parent reply other threads:[~2021-06-21 8:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-18 0:03 [PATCH net-next] net/mlx5: Use cpumask_available() in mlx5_eq_create_generic() Nathan Chancellor
2021-06-21 8:53 ` Leon Romanovsky [this message]
2021-06-22 21:39 ` Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNBToF0+eruEG7JL@unreal \
--to=leon@kernel.org \
--cc=clang-built-linux@googlegroups.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).