From: Konrad Rzeszutek Wilk <konrad@darnok.org>
To: 'Dominique MARTINET' <dominique.martinet@atmark-techno.com>
Cc: "Chanho Park" <chanho61.park@samsung.com>,
"'Jianxiong Gao'" <jxgao@google.com>,
"'Christoph Hellwig'" <hch@lst.de>,
"'Konrad Rzeszutek Wilk'" <konrad.wilk@oracle.com>,
"'Linus Torvalds'" <torvalds@linux-foundation.org>,
"'Horia Geantă'" <horia.geanta@nxp.com>,
linux-kernel@vger.kernel.org,
"'Lukas Hartmann'" <lukas@mntmn.com>,
"'Aymen Sghaier'" <aymen.sghaier@nxp.com>,
"'Herbert Xu'" <herbert@gondor.apana.org.au>,
"'David S. Miller'" <davem@davemloft.net>,
linux-crypto@vger.kernel.org, iommu@lists.linux-foundation.org,
"'Marc Orr'" <marcorr@google.com>,
"'Erdem Aktas'" <erdemaktas@google.com>,
"'Peter Gonda'" <pgonda@google.com>,
"'Bumyong Lee'" <bumyong.lee@samsung.com>
Subject: Re: swiotlb/caamjr regression (Was: [GIT PULL] (swiotlb) stable/for-linus-5.12)
Date: Mon, 21 Jun 2021 09:16:43 -0400 [thread overview]
Message-ID: <YNCROxI328u7IKdQ@fedora> (raw)
In-Reply-To: <YNASOEGsDxhFC8qJ@atmark-techno.com>
On Mon, Jun 21, 2021 at 01:14:48PM +0900, 'Dominique MARTINET' wrote:
> Chanho Park wrote on Mon, Jun 21, 2021 at 11:55:22AM +0900:
> > Sure. No problem. But, the patch was already stacked on Konrad's tree
> > and linux-next as well.
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/konrad/swiotlb.git/commit/?h=devel/for-linus-5.14&id=33d1641f38f0c327bc3e5c21de585c77a6512bc6
>
> That patch is slightly different, it's a rewrite Konrad did that mixes
> in Linus' suggestion[1], which breaks things for the NVMe usecase
> Jianxiong Gao has.
>
> [1] offset = (tlb_addr - mem->start) & (IO_TLB_SIZE - 1)
>
>
> Konrad is aware so I think it shouldn't be submitted :)
The beaty of 'devel' and 'linux-next' is that they can be reshuffled and
mangled. I pushed them original patch from Bumyong there and will let
it sit for a day and then create a stable branch and give it to Linus.
Then I need to expand the test-regression bucket so that this does not
happen again. Dominique, how easy would it be to purchase one of those
devices?
I was originally thinking to create a crypto device in QEMU to simulate
this but that may take longer to write than just getting the real thing.
Or I could create some fake devices with weird offsets and write a driver
for it to exercise this.. like this one I had done some time ago that
needs some brushing off.
next prev parent reply other threads:[~2021-06-21 13:16 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-26 16:00 [GIT PULL] (swiotlb) stable/for-linus-5.12 Konrad Rzeszutek Wilk
2021-02-26 22:24 ` pr-tracker-bot
2021-06-08 2:35 ` swiotlb/caamjr regression (Was: [GIT PULL] (swiotlb) stable/for-linus-5.12) Dominique MARTINET
2021-06-10 14:52 ` Horia Geantă
2021-06-10 19:41 ` Linus Torvalds
2021-06-10 23:20 ` Horia Geantă
2021-06-11 6:21 ` Christoph Hellwig
2021-06-11 10:34 ` Konrad Rzeszutek Wilk
2021-06-11 10:59 ` Horia Geantă
2021-06-11 16:21 ` Linus Torvalds
2021-06-16 20:49 ` Jianxiong Gao
2021-06-17 0:27 ` Konrad Rzeszutek Wilk
2021-06-17 0:39 ` Dominique MARTINET
2021-06-17 5:12 ` Christoph Hellwig
2021-06-17 5:36 ` Dominique MARTINET
2021-06-18 18:01 ` Jianxiong Gao
2021-06-21 2:03 ` Dominique MARTINET
2021-06-21 2:55 ` Chanho Park
2021-06-21 4:14 ` 'Dominique MARTINET'
2021-06-21 13:16 ` Konrad Rzeszutek Wilk [this message]
2021-06-22 7:48 ` 'Dominique MARTINET'
2021-06-22 21:58 ` Konrad Rzeszutek Wilk
2021-06-22 23:04 ` 'Dominique MARTINET'
2021-06-17 11:33 ` Christoph Hellwig
2021-06-11 16:01 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNCROxI328u7IKdQ@fedora \
--to=konrad@darnok.org \
--cc=aymen.sghaier@nxp.com \
--cc=bumyong.lee@samsung.com \
--cc=chanho61.park@samsung.com \
--cc=davem@davemloft.net \
--cc=dominique.martinet@atmark-techno.com \
--cc=erdemaktas@google.com \
--cc=hch@lst.de \
--cc=herbert@gondor.apana.org.au \
--cc=horia.geanta@nxp.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jxgao@google.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas@mntmn.com \
--cc=marcorr@google.com \
--cc=pgonda@google.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).