From: Matthias Kaehlcke <mka@chromium.org>
To: Mike Tipton <mdtipton@codeaurora.org>
Cc: djakov@kernel.org, bjorn.andersson@linaro.org, agross@kernel.org,
okukatla@codeaurora.org, linux-pm@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] interconnect: qcom: icc-rpmh: Consolidate probe functions
Date: Mon, 21 Jun 2021 17:07:50 -0700 [thread overview]
Message-ID: <YNEp1kTcsqRs39tj@google.com> (raw)
In-Reply-To: <20210621214241.13521-1-mdtipton@codeaurora.org>
On Mon, Jun 21, 2021 at 02:42:41PM -0700, Mike Tipton wrote:
> The current probe/remove functions are implemented separately for each
> target, but they are almost identical. Replace them with common
> functions that can be used across all rpmh targets.
>
> Signed-off-by: Mike Tipton <mdtipton@codeaurora.org>
Good catch, the code is indeed very redundant.
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
prev parent reply other threads:[~2021-06-22 0:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-21 21:42 [PATCH] interconnect: qcom: icc-rpmh: Consolidate probe functions Mike Tipton
2021-06-22 0:07 ` Matthias Kaehlcke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNEp1kTcsqRs39tj@google.com \
--to=mka@chromium.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=djakov@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mdtipton@codeaurora.org \
--cc=okukatla@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).