From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FE80C48BC2 for ; Wed, 23 Jun 2021 09:21:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2CEF96044F for ; Wed, 23 Jun 2021 09:21:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230052AbhFWJXT (ORCPT ); Wed, 23 Jun 2021 05:23:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229833AbhFWJXR (ORCPT ); Wed, 23 Jun 2021 05:23:17 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA5B8C061574; Wed, 23 Jun 2021 02:21:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=MP6Lr2ugSjgt2W5qflvD/XdOl7j43g4NIrRBMnDIbmE=; b=NOG5S5QrLtOTIwuMNFl211SEoi xHAsheCHPTX5XSj+hYWOPDYjjenbo2uh+u40l3147rX22hvAV4wLSJ04bo4+JpKNyVghn36Ul2C33 6wEUvVYOhLs2cy1kBhbcg88zIwIbMxoznBOco7SSxis5nnSQXoZN+PAUHDdzIrN9K16hJT86cSa4U D73LDUp0jkP5H8/F+IP004mhyMFLsTvAZZIQoMvKzfQEfHg9OkOlwLNExIDUYGs+CjXs0cEEj/n2u DS8A3hTL7rMP0DPPogxg7Qb95QKF5II5Wy5iRs9DrcS/5V92IEzCUqVaTkcnPKw5hGZLOCLfPVaEl X/kFqHOg==; Received: from 089144193030.atnat0002.highway.a1.net ([89.144.193.30] helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvz3Q-00FFsr-20; Wed, 23 Jun 2021 09:20:22 +0000 Date: Wed, 23 Jun 2021 11:18:04 +0200 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 25/46] mm/writeback: Add folio_start_writeback() Message-ID: References: <20210622121551.3398730-1-willy@infradead.org> <20210622121551.3398730-26-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210622121551.3398730-26-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > +static inline void set_page_writeback_keepwrite(struct page *page) > { > + folio_start_writeback_keepwrite(page_folio(page)); > } > > +static inline bool test_set_page_writeback(struct page *page) > { > + return set_page_writeback(page); > } Shouldn't these be in folio-compat.c as well? Otherwise looks good: Reviewed-by: Christoph Hellwig