From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34D54C48BE5 for ; Wed, 23 Jun 2021 08:09:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 197AA6108E for ; Wed, 23 Jun 2021 08:09:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230160AbhFWILr (ORCPT ); Wed, 23 Jun 2021 04:11:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230118AbhFWILo (ORCPT ); Wed, 23 Jun 2021 04:11:44 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F0FECC061574; Wed, 23 Jun 2021 01:09:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=G2/C+g7cEjGpxRxJL0ocYil2e3AYw7EKbSAba2DuXLU=; b=E1JC7m0IvmEH4Fz1HT1DKWxjeT zxoCiQiIjhKIB6c0yorUjccChfq6Go4cOfJoi0x7yf9TroVoErhgHg38Tp1V+gh35hjuisbcAp/Nz Dj6wcbBT/nnnv8edAHt5GAXryjqRMSg6vjk5VVXLGC9xRbqN3rOHNad3Op8OFyF+RfFPgOUXcZvIQ 7q6bABrGTFM44I6k4Ib+2gwWLf1WkwirHDsi1Ezt4VySCgovI1akHTGXBsw3JFlhupcFBjEV6y5hb BsImcs/rP9rcpygb4RolH4EmeUgCuBuAATwdWQ/87vQs19VHo9424XBcZU3Nbn5Fcsyi3e4a/S/hB Pq5jwZaQ==; Received: from [2001:4bb8:188:3e21:6594:49:139:2b3f] (helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvxvq-00FBzP-Mu; Wed, 23 Jun 2021 08:08:31 +0000 Date: Wed, 23 Jun 2021 10:08:21 +0200 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 10/46] mm/rmap: Add folio_mkclean() Message-ID: References: <20210622121551.3398730-1-willy@infradead.org> <20210622121551.3398730-11-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210622121551.3398730-11-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 22, 2021 at 01:15:15PM +0100, Matthew Wilcox (Oracle) wrote: > Transform page_mkclean() into folio_mkclean() and add a page_mkclean() > wrapper around folio_mkclean(). > > folio_mkclean is 15 bytes smaller than page_mkclean, but the kernel > is enlarged by 33 bytes due to inlining page_folio() into each caller. > This will go away once the callers are converted to use folio_mkclean(). > > Signed-off-by: Matthew Wilcox (Oracle) Looks good, Reviewed-by: Christoph Hellwig