From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2242C48BE5 for ; Wed, 23 Jun 2021 08:13:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C7F456100B for ; Wed, 23 Jun 2021 08:13:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230048AbhFWIPn (ORCPT ); Wed, 23 Jun 2021 04:15:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229881AbhFWIPm (ORCPT ); Wed, 23 Jun 2021 04:15:42 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 622CBC061574; Wed, 23 Jun 2021 01:13:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=MiB3zDfNv10kGNhwlVcglsJXNkF5Cte0DqzDu9o1lWg=; b=k89hJxRVtVmQCl2cF86fRzSzLf hP0kR4H6lEpYEd9+f+WHyE8k/Zqc6veYgSpnX57mWfgrRrrMBumOAqTDRMXZf4kjpm8qzGt/WfdZt ljII0gqzuFmwvf+q0FxhxqFthmh3reaFN7wmibROejgPbqrwKySMa7YNCSCcPNLMGG0myE3q/HIBo POXCsJ11IH3PdGr/P+a0S0VFUIGtFmTGSiayxaxzz15JVQ/XrAxPqF50cySxs/+Z9IdoB4Yr6RhGZ LRzMAk6fWBJN2hQ+OLbNEe2K5mIYDyJUAI74wZRDLmD591pzpeMTUOSzEABK1LbQXjn3T+iH9ucLJ Ft6kE5fA==; Received: from [2001:4bb8:188:3e21:6594:49:139:2b3f] (helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvy01-00FCEY-Nu; Wed, 23 Jun 2021 08:12:52 +0000 Date: Wed, 23 Jun 2021 10:12:40 +0200 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 12/46] mm/memcg: Use the node id in mem_cgroup_update_tree() Message-ID: References: <20210622121551.3398730-1-willy@infradead.org> <20210622121551.3398730-13-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210622121551.3398730-13-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 22, 2021 at 01:15:17PM +0100, Matthew Wilcox (Oracle) wrote: > static struct mem_cgroup_per_node * > -mem_cgroup_page_nodeinfo(struct mem_cgroup *memcg, struct page *page) > +mem_cgroup_nodeinfo(struct mem_cgroup *memcg, int nid) > { > - int nid = page_to_nid(page); > - > return memcg->nodeinfo[nid]; > } I'd just kill this function entirely and open code it into the only caller > - mctz = soft_limit_tree_from_page(page); > + mctz = soft_limit_tree_node(nid); And while were at it, soft_limit_tree_node seems like a completely pointless helper that does nothing but obsfucating the code. While you touch this area it might be worth to spin another patch to just remove it as well.