From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B2FFC48BE5 for ; Wed, 23 Jun 2021 09:44:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 44F5160724 for ; Wed, 23 Jun 2021 09:44:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230161AbhFWJq0 (ORCPT ); Wed, 23 Jun 2021 05:46:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51218 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229833AbhFWJqZ (ORCPT ); Wed, 23 Jun 2021 05:46:25 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 35DECC061574; Wed, 23 Jun 2021 02:44:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=7C0d0QSOIJgNPkF7EDaDfgv7IzlLb87TH4wXPlcx5ZE=; b=WTDIITegJkeMG6KLoyHK9Jtv2H zSsbg2Sm/WhsxcgkppxahEnW1BazGpNCW5gJ0gGPzjWBqOh6Ckz7Jj5zLb1IowDnVcGQdnOW79EN+ UxcF/YPZxBstv1Wgbn6W6RPWxfQ6PbmQNRQ2iSnJjp4AHO596qitCfGqEgXpKfxaU05urAVomY/rv +mr9KpVhrMCeQO/gQr9tEXHX06ISPYoSbB1atdcPraKDAOzHyTz24o6te8XcnMwv6ZhToh0KHJ6Te 5+Z/fj0Z7U9ASIUvXPlplToXvntd50CNLY8h7GpYUNm0pbmntNY7vJX40D07Dj+DMZ7YOYkD3Almo B2AMjHKQ==; Received: from [2001:4bb8:188:3e21:6594:49:139:2b3f] (helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvzPn-00FHFB-4E; Wed, 23 Jun 2021 09:43:39 +0000 Date: Wed, 23 Jun 2021 11:43:20 +0200 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 31/46] mm/writeback: Add folio_clear_dirty_for_io() Message-ID: References: <20210622121551.3398730-1-willy@infradead.org> <20210622121551.3398730-32-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210622121551.3398730-32-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 22, 2021 at 01:15:36PM +0100, Matthew Wilcox (Oracle) wrote: > Transform clear_page_dirty_for_io() into folio_clear_dirty_for_io() > and add a compatibility wrapper. Also move the declaration to pagemap.h > as this is page cache functionality that doesn't need to be used by the > rest of the kernel. > > Increases the size of the kernel by 79 bytes. While we remove a few > calls to compound_head(), we add a call to folio_nr_pages() to get the > stats correct. ... for the eventual support of multi-page folios. Otherwise looks good: Reviewed-by: Christoph Hellwig