From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87E17C48BE5 for ; Wed, 23 Jun 2021 09:45:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6CB5A60725 for ; Wed, 23 Jun 2021 09:45:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230217AbhFWJrb (ORCPT ); Wed, 23 Jun 2021 05:47:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51452 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229833AbhFWJr2 (ORCPT ); Wed, 23 Jun 2021 05:47:28 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B5C81C061574; Wed, 23 Jun 2021 02:45:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=GP93UPkC0hitfxxYgCn7L4t08K/y+OYO9CnmPnYe08Y=; b=MhsBbYroqBJd2MoDpQGLPRoKEZ vJiwFt2VPW7m0BMFpjrgKDSmDUCN8kJMPVEHK6nOR1GmDiOimvhFdVVUH49FaJK6dXlH986l6egSp 0/2A2czQ4bTCZlMON1ohIUKz4REPRL2L+FvddLerAyDWPtYwTz4fYWB12ZoRWd7GwLDrJiQYv+JOt jbBHQ6PlIyi1UCdMSUwPzE4DPLuQB5se590lRcEh89R9aNRxml6iK0s2VSi1J4eu2130ubjEziOFw Zsvj8lEr8TC+Em7GJ3a9dh5kjbIro5RGTrcqnhodRiX8fm6e3hWCGH2n+60dHDkyljws0hWTp54nu ZBEBxm3g==; Received: from [2001:4bb8:188:3e21:6594:49:139:2b3f] (helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvzQh-00FHHv-7U; Wed, 23 Jun 2021 09:44:33 +0000 Date: Wed, 23 Jun 2021 11:44:18 +0200 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 32/46] mm/writeback: Add folio_account_redirty() Message-ID: References: <20210622121551.3398730-1-willy@infradead.org> <20210622121551.3398730-33-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210622121551.3398730-33-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 22, 2021 at 01:15:37PM +0100, Matthew Wilcox (Oracle) wrote: > Account the number of pages in the folio that we're redirtying. > Turn account_page_dirty() into a wrapper around it. Also turn > the comment on folio_account_redirty() into kernel-doc and > edit it slightly so it makes sense to its potential callers. > > Signed-off-by: Matthew Wilcox (Oracle) Looks good, Reviewed-by: Christoph Hellwig