From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 656DBC48BE5 for ; Wed, 23 Jun 2021 09:50:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4AAEA60FEB for ; Wed, 23 Jun 2021 09:50:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230302AbhFWJxK (ORCPT ); Wed, 23 Jun 2021 05:53:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52768 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229833AbhFWJxI (ORCPT ); Wed, 23 Jun 2021 05:53:08 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 65D4CC061574; Wed, 23 Jun 2021 02:50:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=wX68kOPzYETyqJ2SCKqkqr7ukc9cCZeyMzMIUFAMr1E=; b=XjutMCRefnRt22zx8OdxtQ4Jsg G0r0exLUeLlGZZJ2j24THQD6fRqFPEuAXiq0Dshb3s0GUgZe+QEUorXxMlYKxO4F9zyL4Fdk8CfZn v4KNESEHhSvdB46CAz7mlCGzgJ6WCEZU4UVb4k3uOjmUmzIsk+1rqrhiC517KTkOCglo+8RiMqYxT SX/9lMehzoV76Ms83Y5kVTb3Bfw1/KyPX3p5zmrQ4il5X37RrzfaDgStrud1IT6P/mZ6oT2eltFM4 Pb6u9YvlQngryCf4uIS+9F1fizTp83sRZNIXMfVQHDLh1etXSGYUqxY+bO2yydSUeCT84kL5yT4k1 8XHyxp9w==; Received: from [2001:4bb8:188:3e21:6594:49:139:2b3f] (helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvzWH-00FHgM-KV; Wed, 23 Jun 2021 09:50:13 +0000 Date: Wed, 23 Jun 2021 11:50:04 +0200 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 36/46] mm/filemap: Add readahead_folio() Message-ID: References: <20210622121551.3398730-1-willy@infradead.org> <20210622121551.3398730-37-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210622121551.3398730-37-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 22, 2021 at 01:15:41PM +0100, Matthew Wilcox (Oracle) wrote: > The pointers stored in the page cache are folios, by definition. > This change comes with a behaviour change -- callers of readahead_folio() > are no longer required to put the page reference themselves. This matches > how readpage works, rather than matching how readpages used to work. The way this stores and retrieves different but compatible types from the same xarray is a little nasty. But I guess we'll have to live with it for now, so: Reviewed-by: Christoph Hellwig