From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: "Christian Löhle" <CLoehle@hyperstone.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"rafael@kernel.org" <rafael@kernel.org>
Subject: Re: [PATCH] kobject: Safe return of kobject_get_path with NULL
Date: Wed, 23 Jun 2021 17:11:26 +0200 [thread overview]
Message-ID: <YNNPHvFWoeI4UwEZ@kroah.com> (raw)
In-Reply-To: <CWXP265MB2680094534A5559B0A904B76C4089@CWXP265MB2680.GBRP265.PROD.OUTLOOK.COM>
On Wed, Jun 23, 2021 at 02:47:35PM +0000, Christian Löhle wrote:
> Prevent NULL dereference within get_kobj_path_length
>
> Calling kobject_get_path could provoke a NULL dereference
> if NULL was passed. while fill_kobj_path will return
> with a sane 0 for NULL, kobjet_get_path_length did not.
Who passes NULL into that function? Shouldn't that be fixed first?
>
> Signed-off-by: Christian Loehle <cloehle@hyperstone.com>
> ---
> lib/kobject.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/lib/kobject.c b/lib/kobject.c
> index ea53b30cf483..735159c13a94 100644
> --- a/lib/kobject.c
> +++ b/lib/kobject.c
> @@ -130,6 +130,8 @@ static int get_kobj_path_length(struct kobject *kobj)
> {
> int length = 1;
> struct kobject *parent = kobj;
> + if (!kobj)
> + return 0;
>
> /* walk up the ancestors until we hit the one pointing to the
> * root.
> --
> 2.32.0
>
> Hyperstone GmbH | Line-Eid-Strasse 3 | 78467 Konstanz
> Managing Directors: Dr. Jan Peter Berns.
> Commercial register of local courts: Freiburg HRB381782
>
Pleaase always run your patches through checkpatch.pl so you do not get
maintainers asking you to use checkpatch.pl...
thanks,
greg k-h
next prev parent reply other threads:[~2021-06-23 15:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-23 14:47 [PATCH] kobject: Safe return of kobject_get_path with NULL Christian Löhle
2021-06-23 14:49 ` Christian Löhle
2021-06-23 15:12 ` gregkh
2021-06-23 15:11 ` gregkh [this message]
2021-06-24 6:42 ` Christian Löhle
2021-06-24 9:02 ` gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNNPHvFWoeI4UwEZ@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=CLoehle@hyperstone.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).