From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B111C49EA5 for ; Wed, 23 Jun 2021 20:49:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0DD5E610A0 for ; Wed, 23 Jun 2021 20:49:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229906AbhFWUvd (ORCPT ); Wed, 23 Jun 2021 16:51:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60646 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229800AbhFWUvc (ORCPT ); Wed, 23 Jun 2021 16:51:32 -0400 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 85FF4C061574 for ; Wed, 23 Jun 2021 13:49:13 -0700 (PDT) Received: by mail-pj1-x102d.google.com with SMTP id g24so2181446pji.4 for ; Wed, 23 Jun 2021 13:49:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=SJKphL8uOUhd6liKj++z6WVQVSyBvdXtPp4yiTiG0+g=; b=PQlAN3JA0b1xAhCl8OBNeH+zKs/l2VBcECbikSgi+dHCFDxLK38FY+HyXZlWyV9WSJ 6iUUCqtAXH1tDO2QR6+HRti3vBJ652t6wv3q8fodPa8fXxb51+wDyxRiqteiPRE7Zmbj 4f9dOegBimsVqOBfmTcOkyNAyv+7WsrwZVF6ps3PNoGYNHJVRmF5BuyQi1BCIGdJ3bwS JUNPwEG5a6No7TUYJbk2DYO2+jUGLRiJhSeMIQ6KXgjYrUoHKCta+fOxuFOFY4rd1XZr gWffZjGebFM+1ZcFHn0KS64hoa0gJCEofpLZexuss3hJT+Hx4zE40uzVBJ74eDjeCbdp l+rA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=SJKphL8uOUhd6liKj++z6WVQVSyBvdXtPp4yiTiG0+g=; b=pTbWvIs/Z9v60MULvnAF6upAC+K7FIS39+zshnikUIhIqH13dXvnxYu6jUuxJ7+n/C O0FM3wdmqk0Nal0AHdG7QWG2yhjX7jPR62/qezgZcTMF4/XSq9FMF8NEvlX1VrG/Qsk3 kDBZW9us8PqMfsTM4nH2u7svwsy2zLiwxOe66GgNj6Mccp4sWsVgepmOwLknJQ1Sn07k AsRYpMEK1YyQYPLkYShM15dOhEiam3fmZaUZMUmTv0v3lqzPt+3gDVWhImqRHsv5Okui B0+ZEmmJrpVb11t55WJGvZMBbTh1Ijen0M3s94926/kLEyeAbpTzQLH05fRVC7Mmswto w/dg== X-Gm-Message-State: AOAM530DpaiJKFhDM3p7Dl8eJ5zjfar6HOWW5ihMx7brBEGN32Vs4oEN qxLRN09S5OxZPsf7iVUNbtNV2w== X-Google-Smtp-Source: ABdhPJy4bUIJIg5BnVOL2fOwy2ZwQLeXBKBMHJPepyjsPHZYqtQS6DHJVMfo3EBMLjG+fDeYdpwAOg== X-Received: by 2002:a17:90a:694d:: with SMTP id j13mr1526258pjm.99.1624481352832; Wed, 23 Jun 2021 13:49:12 -0700 (PDT) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id oc9sm173802pjb.43.2021.06.23.13.49.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Jun 2021 13:49:12 -0700 (PDT) Date: Wed, 23 Jun 2021 20:49:08 +0000 From: Sean Christopherson To: Paolo Bonzini Cc: Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Yu Zhang , Maxim Levitsky Subject: Re: [PATCH 15/54] KVM: nSVM: Add a comment to document why nNPT uses vmcb01, not vCPU state Message-ID: References: <20210622175739.3610207-1-seanjc@google.com> <20210622175739.3610207-16-seanjc@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 23, 2021, Paolo Bonzini wrote: > On 22/06/21 19:57, Sean Christopherson wrote: > > + /* > > + * L1's CR4 and EFER are stuffed into vmcb01 by the caller. Note, when > > + * called via KVM_SET_NESTED_STATE, that state may_not_ match current > > + * vCPU state. CR0.WP is explicitly ignored, while CR0.PG is required. > > + */ > > "stuffed into" doesn't really match reality of vmentry, though it works for > KVM_SET_NESTED_STATE. What about a more neutral "The NPT format depends on > L1's CR4 and EFER, which is in vmcb01"? Ah, true. Works for me.