From: Andrew Lunn <andrew@lunn.ch>
To: Marcin Wojtas <mw@semihalf.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Russell King - ARM Linux <linux@armlinux.org.uk>,
Grzegorz Jaszczyk <jaz@semihalf.com>,
Grzegorz Bernacki <gjb@semihalf.com>,
upstream@semihalf.com,
Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>,
Jon Nettleton <jon@solid-run.com>,
Tomasz Nowicki <tn@semihalf.com>,
rjw@rjwysocki.net, lenb@kernel.org
Subject: Re: [net-next: PATCH v3 4/6] net: mvmdio: add ACPI support
Date: Thu, 24 Jun 2021 03:24:32 +0200 [thread overview]
Message-ID: <YNPe0JyCuHxOQBPZ@lunn.ch> (raw)
In-Reply-To: <CAPv3WKc5G07Te2yK+zJo=M0w-fmPVDZ3_YgNoO-BbssWHLtU7Q@mail.gmail.com>
On Wed, Jun 23, 2021 at 11:58:14PM +0200, Marcin Wojtas wrote:
> śr., 23 cze 2021 o 22:28 Andrew Lunn <andrew@lunn.ch> napisał(a):
> >
> > On Mon, Jun 21, 2021 at 07:30:26PM +0200, Marcin Wojtas wrote:
> > > This patch introducing ACPI support for the mvmdio driver by adding
> > > acpi_match_table with two entries:
> > >
> > > * "MRVL0100" for the SMI operation
> > > * "MRVL0101" for the XSMI mode
> >
> > Same as the freescale MDIO bus driver, you should add
> >
> > depends on FWNODE_MDIO
> >
> > Otherwise you might find randconfig builds end up with it disabled,
> > and then linker errors.
> >
>
> The CONFIG_MVMDIO is selected by CONFIG_MV643XX_ETH and actually there
> is a real example of the previously discussed fallback to the
> mdiobus_register() (without DT/ACPI and now FWNODE_MDIO). I just
> checked and successfully built the kernel out of the dove_defconfig. I
> only needed below fix, that will be submitted in v4:
You could be correct, but i've seen randconfig builds find issues. So
i tend to add dependencies to avoid possible problems. Such problem
reports tend to come weeks later, when Arnd does such builds.
Andrew
next prev parent reply other threads:[~2021-06-24 1:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-21 17:30 [net-next: PATCH v3 0/6] ACPI MDIO support for Marvell controllers Marcin Wojtas
2021-06-21 17:30 ` [net-next: PATCH v3 1/6] Documentation: ACPI: DSD: describe additional MAC configuration Marcin Wojtas
2021-06-23 20:18 ` Andrew Lunn
2021-06-23 21:00 ` Marcin Wojtas
2021-06-23 21:36 ` Andrew Lunn
2021-06-23 21:42 ` Vladimir Oltean
2021-06-21 17:30 ` [net-next: PATCH v3 2/6] net: mdiobus: Introduce fwnode_mdbiobus_register() Marcin Wojtas
2021-06-23 20:22 ` Andrew Lunn
2021-06-23 22:10 ` Marcin Wojtas
2021-06-24 11:10 ` Marcin Wojtas
2021-06-21 17:30 ` [net-next: PATCH v3 3/6] net/fsl: switch to fwnode_mdiobus_register Marcin Wojtas
2021-06-23 20:24 ` Andrew Lunn
2021-06-21 17:30 ` [net-next: PATCH v3 4/6] net: mvmdio: add ACPI support Marcin Wojtas
2021-06-23 20:28 ` Andrew Lunn
2021-06-23 21:58 ` Marcin Wojtas
2021-06-24 1:24 ` Andrew Lunn [this message]
2021-06-21 17:30 ` [net-next: PATCH v3 5/6] net: mvpp2: enable using phylink with ACPI Marcin Wojtas
2021-06-23 20:37 ` Andrew Lunn
2021-06-23 21:45 ` Marcin Wojtas
2021-06-24 1:17 ` Andrew Lunn
2021-06-21 17:30 ` [net-next: PATCH v3 6/6] net: mvpp2: remove unused 'has_phy' field Marcin Wojtas
2021-06-23 11:56 ` [net-next: PATCH v3 0/6] ACPI MDIO support for Marvell controllers Marcin Wojtas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNPe0JyCuHxOQBPZ@lunn.ch \
--to=andrew@lunn.ch \
--cc=Samer.El-Haj-Mahmoud@arm.com \
--cc=davem@davemloft.net \
--cc=gjb@semihalf.com \
--cc=jaz@semihalf.com \
--cc=jon@solid-run.com \
--cc=kuba@kernel.org \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mw@semihalf.com \
--cc=netdev@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tn@semihalf.com \
--cc=upstream@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).