From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88DB6C49EA7 for ; Thu, 24 Jun 2021 08:47:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6CC2A613D8 for ; Thu, 24 Jun 2021 08:47:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230006AbhFXItU (ORCPT ); Thu, 24 Jun 2021 04:49:20 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:54360 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229573AbhFXItS (ORCPT ); Thu, 24 Jun 2021 04:49:18 -0400 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 807FF1FD67; Thu, 24 Jun 2021 08:46:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1624524418; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wk6ST5cyENRzxS8gwOtJfNeloqq3+v5ssPqG3osnJgE=; b=VANKUxcgbmb1ncSSPP+/2xOJkd5PY+9dW6wKnQmIWUC0RGzW5yyczXY1YkMAM3Q23RzWYf iO3i2FG2J+6v09Bo74vRWyIHNaokZhEwuh4mCgbjE78ukP9DdBNmbs3IsSGKmRuRFBwCTH kf76LaGdYvo8NDRZTla7zw6ZCDSywfg= Received: from suse.cz (unknown [10.100.224.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id C00EEA3BB2; Thu, 24 Jun 2021 08:46:57 +0000 (UTC) Date: Thu, 24 Jun 2021 10:46:56 +0200 From: Petr Mladek To: Justin He Cc: Andy Shevchenko , Steven Rostedt , Sergey Senozhatsky , Rasmus Villemoes , Jonathan Corbet , Alexander Viro , Linus Torvalds , "Peter Zijlstra (Intel)" , Eric Biggers , "Ahmed S. Darwish" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , Matthew Wilcox , Christoph Hellwig , nd Subject: Re: [PATCH v5 2/4] lib/vsprintf.c: make '%pD' print the full path of file Message-ID: References: <20210622140634.2436-1-justin.he@arm.com> <20210622140634.2436-3-justin.he@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 2021-06-23 03:14:33, Justin He wrote: > Hi Andy > > > -----Original Message----- > > From: Andy Shevchenko > > Sent: Tuesday, June 22, 2021 10:40 PM > > To: Justin He > > Cc: Petr Mladek ; Steven Rostedt ; > > Sergey Senozhatsky ; Rasmus Villemoes > > ; Jonathan Corbet ; Alexander > > Viro ; Linus Torvalds > foundation.org>; Peter Zijlstra (Intel) ; Eric > > Biggers ; Ahmed S. Darwish ; > > linux-doc@vger.kernel.org; linux-kernel@vger.kernel.org; linux- > > fsdevel@vger.kernel.org; Matthew Wilcox ; Christoph > > Hellwig ; nd > > Subject: Re: [PATCH v5 2/4] lib/vsprintf.c: make '%pD' print the full path > > of file > > > > On Tue, Jun 22, 2021 at 10:06:32PM +0800, Jia He wrote: > > > Previously, the specifier '%pD' is for printing dentry name of struct > > > file. It may not be perfect (by default it only prints one component.) > > > > > > As suggested by Linus [1]: > > > > Citing is better looked when you shift right it by two white spaces. > > Okay, I plan to cite it with "> " My understanding is that Andy suggested to omit '>' and prefix it by plain two spaces " ". It would look better to me as well. Best Regards, Petr