* [PATCH] dmaengine: xilinx: dpdma: Fix spacing around addr[i-1]
@ 2021-06-23 11:07 Michal Simek
2021-06-23 12:59 ` Laurent Pinchart
2021-06-24 11:10 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Michal Simek @ 2021-06-23 11:07 UTC (permalink / raw)
To: linux-kernel, monstr, michal.simek, git
Cc: Hyun Kwon, Laurent Pinchart, Vinod Koul, dmaengine, linux-arm-kernel
Use proper spacing for array calculation. Issue is reported by
checkpatch.pl --strict.
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---
drivers/dma/xilinx/xilinx_dpdma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/xilinx/xilinx_dpdma.c b/drivers/dma/xilinx/xilinx_dpdma.c
index 0b67083c95d0..b280a53e8570 100644
--- a/drivers/dma/xilinx/xilinx_dpdma.c
+++ b/drivers/dma/xilinx/xilinx_dpdma.c
@@ -531,7 +531,7 @@ static void xilinx_dpdma_sw_desc_set_dma_addrs(struct xilinx_dpdma_device *xdev,
for (i = 1; i < num_src_addr; i++) {
u32 *addr = &hw_desc->src_addr2;
- addr[i-1] = lower_32_bits(dma_addr[i]);
+ addr[i - 1] = lower_32_bits(dma_addr[i]);
if (xdev->ext_addr) {
u32 *addr_ext = &hw_desc->addr_ext_23;
--
2.32.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dmaengine: xilinx: dpdma: Fix spacing around addr[i-1]
2021-06-23 11:07 [PATCH] dmaengine: xilinx: dpdma: Fix spacing around addr[i-1] Michal Simek
@ 2021-06-23 12:59 ` Laurent Pinchart
2021-06-24 11:10 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Pinchart @ 2021-06-23 12:59 UTC (permalink / raw)
To: Michal Simek
Cc: linux-kernel, monstr, git, Hyun Kwon, Vinod Koul, dmaengine,
linux-arm-kernel
On Wed, Jun 23, 2021 at 01:07:38PM +0200, Michal Simek wrote:
> Use proper spacing for array calculation. Issue is reported by
> checkpatch.pl --strict.
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
> drivers/dma/xilinx/xilinx_dpdma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/xilinx/xilinx_dpdma.c b/drivers/dma/xilinx/xilinx_dpdma.c
> index 0b67083c95d0..b280a53e8570 100644
> --- a/drivers/dma/xilinx/xilinx_dpdma.c
> +++ b/drivers/dma/xilinx/xilinx_dpdma.c
> @@ -531,7 +531,7 @@ static void xilinx_dpdma_sw_desc_set_dma_addrs(struct xilinx_dpdma_device *xdev,
> for (i = 1; i < num_src_addr; i++) {
> u32 *addr = &hw_desc->src_addr2;
>
> - addr[i-1] = lower_32_bits(dma_addr[i]);
> + addr[i - 1] = lower_32_bits(dma_addr[i]);
I don't mind either way.
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> if (xdev->ext_addr) {
> u32 *addr_ext = &hw_desc->addr_ext_23;
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dmaengine: xilinx: dpdma: Fix spacing around addr[i-1]
2021-06-23 11:07 [PATCH] dmaengine: xilinx: dpdma: Fix spacing around addr[i-1] Michal Simek
2021-06-23 12:59 ` Laurent Pinchart
@ 2021-06-24 11:10 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2021-06-24 11:10 UTC (permalink / raw)
To: Michal Simek
Cc: linux-kernel, monstr, git, Hyun Kwon, Laurent Pinchart,
dmaengine, linux-arm-kernel
On 23-06-21, 13:07, Michal Simek wrote:
> Use proper spacing for array calculation. Issue is reported by
> checkpatch.pl --strict.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-24 11:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-23 11:07 [PATCH] dmaengine: xilinx: dpdma: Fix spacing around addr[i-1] Michal Simek
2021-06-23 12:59 ` Laurent Pinchart
2021-06-24 11:10 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).