From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D27DC48BDF for ; Thu, 24 Jun 2021 12:58:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 389236128D for ; Thu, 24 Jun 2021 12:58:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231945AbhFXNAh (ORCPT ); Thu, 24 Jun 2021 09:00:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:45146 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231467AbhFXNAg (ORCPT ); Thu, 24 Jun 2021 09:00:36 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5432C613C3; Thu, 24 Jun 2021 12:58:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1624539496; bh=5HgfKV3KNHodF5YVB0C/oGwC4UwPn2YZnTEjr0F4kgU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NVHhKZ7MdoETAo3P4bip9WJhMoTg66WO9SSqVOeuosPsv2V+OXeXuhosGW78rhWQr VFC1MKVMxfpf6tL8oIr0yQD3N54ymU3mqk3nMeDebaobQzIWTdud16xNrS1MismEOt Khri9r0rM9V/l6/bfrgngw6zYp16eGRDCL17fp6M= Date: Thu, 24 Jun 2021 14:58:14 +0200 From: Greg KH To: Zhenguo Zhao Cc: jirislaby@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] tty: n_gsm: CR bit value should be 0 when config "initiator=0" Message-ID: References: <1623844402-4731-1-git-send-email-zhenguo6858@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1623844402-4731-1-git-send-email-zhenguo6858@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 16, 2021 at 07:53:22PM +0800, Zhenguo Zhao wrote: > From: Zhenguo Zhao > > config "initiator=0",gsmld will receives dlci SABM/DISC control command > frame,as slaver,the CR bit value check should be 1. I am really sorry, but I do not understand this changelog comment. Can you try rewriting it again? > > if check "cr == 0",it will goto invalid,so it can't send UA response > frame and open slaver dlci. Same here, I do not understand. thanks, greg k-h