From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11CFEC49EA7 for ; Thu, 24 Jun 2021 13:53:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E7EA1613F3 for ; Thu, 24 Jun 2021 13:53:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231436AbhFXNz5 (ORCPT ); Thu, 24 Jun 2021 09:55:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:39462 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229878AbhFXNzz (ORCPT ); Thu, 24 Jun 2021 09:55:55 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6F24C613ED; Thu, 24 Jun 2021 13:53:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1624542815; bh=WuGclsAxOiYq/aCZOLJGuJCShfXRC5h/rYQlt1bwn4E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=te5oQlEds6nbZ9Wx4nJf7eOu16XxBbeYfAPYhWrk2+DAEKH5GXaZMZLPV06iazGf8 GbOPmnJVpIRMtZk8wFbTR2itW7WXPWLnCLiTO6NYKnVwalPeOYbGAXVpJcqh99F3Kr xGHoV++Utns99LPkffOYzd+u/ZTYS7n8U9uWmROw= Date: Thu, 24 Jun 2021 15:53:33 +0200 From: Greg KH To: Manivannan Sadhasivam Cc: hemantk@codeaurora.org, bbhatt@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, loic.poulain@linaro.org Subject: Re: [PATCH 6/8] bus: mhi: core: Add support for processing priority of event ring Message-ID: References: <20210621161616.77524-1-manivannan.sadhasivam@linaro.org> <20210621161616.77524-7-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210621161616.77524-7-manivannan.sadhasivam@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 21, 2021 at 09:46:14PM +0530, Manivannan Sadhasivam wrote: > From: Hemant Kumar > > Event ring priorities are currently set to 1 and are unused. > Default processing priority for event rings is set to regular > tasklet. Controllers can choose to use high priority tasklet > scheduling for certain event rings critical for processing such > as ones transporting control information if they wish to avoid > system scheduling delays for those packets. In order to support > these use cases, allow controllers to set event ring priority to > high. > > Signed-off-by: Hemant Kumar > Signed-off-by: Bhaumik Bhatt > Reviewed-by: Manivannan Sadhasivam > Link: https://lore.kernel.org/r/1624053903-24653-2-git-send-email-bbhatt@codeaurora.org > Signed-off-by: Manivannan Sadhasivam > --- > drivers/bus/mhi/core/init.c | 3 +-- > drivers/bus/mhi/core/main.c | 9 +++++++-- > include/linux/mhi.h | 2 +- > 3 files changed, 9 insertions(+), 5 deletions(-) > > diff --git a/drivers/bus/mhi/core/init.c b/drivers/bus/mhi/core/init.c > index c81b377fca8f..444676034bf0 100644 > --- a/drivers/bus/mhi/core/init.c > +++ b/drivers/bus/mhi/core/init.c > @@ -673,8 +673,7 @@ static int parse_ev_cfg(struct mhi_controller *mhi_cntrl, > &mhi_cntrl->mhi_chan[mhi_event->chan]; > } > > - /* Priority is fixed to 1 for now */ > - mhi_event->priority = 1; > + mhi_event->priority = event_cfg->priority; > > mhi_event->db_cfg.brstmode = event_cfg->mode; > if (MHI_INVALID_BRSTMODE(mhi_event->db_cfg.brstmode)) > diff --git a/drivers/bus/mhi/core/main.c b/drivers/bus/mhi/core/main.c > index 8ac73f9e92a6..3775c77dec63 100644 > --- a/drivers/bus/mhi/core/main.c > +++ b/drivers/bus/mhi/core/main.c > @@ -454,10 +454,15 @@ irqreturn_t mhi_irq_handler(int irq_number, void *dev) > > if (mhi_dev) > mhi_notify(mhi_dev, MHI_CB_PENDING_DATA); > - } else { > - tasklet_schedule(&mhi_event->task); > + > + return IRQ_HANDLED; > } > > + if (!mhi_event->priority) > + tasklet_hi_schedule(&mhi_event->task); > + else > + tasklet_schedule(&mhi_event->task); > + > return IRQ_HANDLED; > } > > diff --git a/include/linux/mhi.h b/include/linux/mhi.h > index 86cea5256e3c..bf23c213429c 100644 > --- a/include/linux/mhi.h > +++ b/include/linux/mhi.h > @@ -250,7 +250,7 @@ struct mhi_channel_config { > * @irq_moderation_ms: Delay irq for additional events to be aggregated > * @irq: IRQ associated with this ring > * @channel: Dedicated channel number. U32_MAX indicates a non-dedicated ring > - * @priority: Priority of this ring. Use 1 for now > + * @priority: Processing priority of this ring. 0 is high and 1 is regular Why is 0 high and 1 low? Does that feel backwards? Shouldn't this be a boolean, or if not, an enumerated type so that people can read the code over time? thanks, greg k-h