From: Andrew Lunn <andrew@lunn.ch>
To: Wolfram Sang <wsa@kernel.org>, Johan Hovold <johan@kernel.org>,
linux-i2c@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org,
syzbot+9d7dadd15b8819d73f41@syzkaller.appspotmail.com,
stable@vger.kernel.org
Subject: Re: [PATCH] i2c: robotfuzz-osif: fix control-request directions
Date: Thu, 24 Jun 2021 22:32:05 +0200 [thread overview]
Message-ID: <YNTrxT9gRrfMlN+2@lunn.ch> (raw)
In-Reply-To: <YNTmqcrYb9KzW8Zh@kunai>
On Thu, Jun 24, 2021 at 10:10:17PM +0200, Wolfram Sang wrote:
> On Wed, Jun 23, 2021 at 10:52:04AM +0200, Johan Hovold wrote:
> > On Mon, May 24, 2021 at 11:09:12AM +0200, Johan Hovold wrote:
> > > The direction of the pipe argument must match the request-type direction
> > > bit or control requests may fail depending on the host-controller-driver
> > > implementation.
> > >
> > > Control transfers without a data stage are treated as OUT requests by
> > > the USB stack and should be using usb_sndctrlpipe(). Failing to do so
> > > will now trigger a warning.
> > >
> > > Fix the OSIFI2C_SET_BIT_RATE and OSIFI2C_STOP requests which erroneously
> > > used the osif_usb_read() helper and set the IN direction bit.
> > >
> > > Reported-by: syzbot+9d7dadd15b8819d73f41@syzkaller.appspotmail.com
> > > Fixes: 83e53a8f120f ("i2c: Add bus driver for for OSIF USB i2c device.")
> > > Cc: stable@vger.kernel.org # 3.14
> > > Cc: Andrew Lunn <andrew@lunn.ch>
> > > Signed-off-by: Johan Hovold <johan@kernel.org>
> > > ---
> >
> > Wolfram, can you pick this one up for 5.14?
>
> Sorry, I thought Andrew was the maintainer of this driver and was
> waiting for his ack.
Ah, sorry. I did take a quick look at the change, it seemed
sensible. But i've not used this hardware in years, i have no way to
test it, etc.
Andrew
next prev parent reply other threads:[~2021-06-24 20:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-24 9:09 [PATCH] i2c: robotfuzz-osif: fix control-request directions Johan Hovold
2021-06-23 8:52 ` Johan Hovold
2021-06-24 20:10 ` Wolfram Sang
2021-06-24 20:32 ` Andrew Lunn [this message]
2021-06-25 12:47 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNTrxT9gRrfMlN+2@lunn.ch \
--to=andrew@lunn.ch \
--cc=johan@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=syzbot+9d7dadd15b8819d73f41@syzkaller.appspotmail.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).