From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C751DC49EA7 for ; Thu, 24 Jun 2021 23:45:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AB76E613AD for ; Thu, 24 Jun 2021 23:45:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232908AbhFXXrV (ORCPT ); Thu, 24 Jun 2021 19:47:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57320 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232845AbhFXXrS (ORCPT ); Thu, 24 Jun 2021 19:47:18 -0400 Received: from mail-oo1-xc2f.google.com (mail-oo1-xc2f.google.com [IPv6:2607:f8b0:4864:20::c2f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA014C061766 for ; Thu, 24 Jun 2021 16:44:58 -0700 (PDT) Received: by mail-oo1-xc2f.google.com with SMTP id b17-20020a4aba110000b029024c219a3d83so913148oop.10 for ; Thu, 24 Jun 2021 16:44:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=/IZo+xMlntd1OPotYsAVSJXAdOf8XBCFm8hpgOD3AFg=; b=AfbC8GUOrGiQ8wmQ44iEw4DbrAILKvySD0JZd8pYtbCZY+ekpRhYJmeY9a9vlLZO0W TLhSAmN2KJ0v5+kL3d5oSjkPIhRsBHoa5yjedwB/iE2GW3V5jiQR5yQTNGNKt45aj0IX RhaZfVSTvkWIPxrDVNYG0iuatUSYpf8ZEfSyLoo7rxPEMXkex0D6LI/ZKthaqXsZ7T9/ iAS5EbMp+vVOVpPSd6pjrYRihgMaPAc6kP1kZX/LgKh/6YwUa+U4+neU88eOL72zNn30 BUMICqoJfoLnHIxAXKooFmy5UK1eIMFjMLE6EdXkN91pao8KfVTcPkfQNE6Dq/wlPjyl i6kQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/IZo+xMlntd1OPotYsAVSJXAdOf8XBCFm8hpgOD3AFg=; b=az+Y/vgrUZjqDkW7ac0Y/tQ0XT6YEcRZ8Tbl63H7Z+xzha6jfKeGzkOwKoawvndDo7 OAqo/mgJVitCnO78dKFEm3D53YnfajPZouEG7mlQGhNrPkbyPllyD7yEMUVdqEO4LLpr P8418l2wan9syireuGgibt3dukjy+GiWzvtwhczNbjESbscfukrD2kmYxLFNkVcHCBTk PkshTs4RrUoz4z/idoISsoObSHMyN4XjvGNI+czTPb2QGXqwz0ZSTRcdob+07lD02WHB r2rVyfRVecawUvpW22wilTweMpZkKtz7/bW72p+wrO2jHFVWskaccXcjwdt8t/meRlzy XWsg== X-Gm-Message-State: AOAM530LtcQj3xL3xCQXXKypN/HwCBDcAUg0OttWJZtYDWVYE4hZxrwX vsOvyb0MKzc6RrmxPlePFZn9XQ== X-Google-Smtp-Source: ABdhPJwMXtC7tWjEChYW9HirB1ul2n/Er3ur/GzHXRcQfV3ZScePSyTVNBRmWl7SHAjdME54L0HrIA== X-Received: by 2002:a4a:cb06:: with SMTP id r6mr6597797ooq.15.1624578297522; Thu, 24 Jun 2021 16:44:57 -0700 (PDT) Received: from yoga (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id 35sm980557oti.65.2021.06.24.16.44.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Jun 2021 16:44:57 -0700 (PDT) Date: Thu, 24 Jun 2021 18:44:54 -0500 From: Bjorn Andersson To: Marek Behun Cc: Pavel Machek , Rob Herring , Andy Gross , Thierry Reding , Uwe Kleine-K?nig , Lee Jones , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-pwm@vger.kernel.org, Marijn Suijten , Yassine Oudjana , Luca Weiss , Subbaraman Narayanamurthy Subject: Re: [PATCH v9 1/2] dt-bindings: leds: Add Qualcomm Light Pulse Generator binding Message-ID: References: <20210623035039.772660-1-bjorn.andersson@linaro.org> <20210625011932.6354e397@thinkpad> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210625011932.6354e397@thinkpad> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 24 Jun 18:19 CDT 2021, Marek Behun wrote: > On Tue, 22 Jun 2021 20:50:38 -0700 > Bjorn Andersson wrote: > > > +++ b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml > > The file name should be based on one of the compatible strings, for > example the first one: > qcom,pm8150b-lpg.yaml > The majority of the files in leds/ are named leds-*.yaml, is this a new scheme for LED bindings? > > + led@1 { > > + reg = <1>; > > + label = "green:user1"; > > + }; > > `label` is deprecated, Sorry, I missed the comment in the middle of the description about this. Is there any particular reason why this isn't marked deprecated: true? > please don't use in new bindings in examples. > Instead use color, function and function-enumerator, i.e. > > color = ; > function = LED_FUNCTION_xxx; > function-enumerator = ; > Can you point me to something helping me regarding what "function" to use? For this particular devboard that the example comes from I have 4 LEDs that are named "user1", "user2", "user3" and "user4" in the board documentation. I can make up whatever for the example, but I would like to get the following dts additions follow the expected guidelines. Regards, Bjorn