From: Alexey Dobriyan <adobriyan@gmail.com>
To: akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, Miguel Ojeda <ojeda@kernel.org>
Subject: [PATCH v2] ELF: add and use SUPPRESS_WARN_UNUSED_RESULT
Date: Sat, 26 Jun 2021 00:13:12 +0300 [thread overview]
Message-ID: <YNZG6N0W/7gjG7Gm@localhost.localdomain> (raw)
In-Reply-To: <YNYz+hVeqsQmiEqN@localhost.localdomain>
Last write to the "error" variable in load_elf_binary() is dead write.
Add and use SUPPRESS_WARN_UNUSED_RESULT macro to express intent better.
Credit goes to Ed Catmur:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66425#c34
Macro doesn't work for WUR functions returning structures and unions,
but it will work when gcc copies clang.
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---
fs/binfmt_elf.c | 3 ++-
include/linux/compiler_attributes.h | 4 ++++
2 files changed, 6 insertions(+), 1 deletion(-)
--- a/fs/binfmt_elf.c
+++ b/fs/binfmt_elf.c
@@ -1290,7 +1290,8 @@ static int load_elf_binary(struct linux_binprm *bprm)
and some applications "depend" upon this behavior.
Since we do not have the power to recompile these, we
emulate the SVr4 behavior. Sigh. */
- error = vm_mmap(NULL, 0, PAGE_SIZE, PROT_READ | PROT_EXEC,
+ SUPPRESS_WARN_UNUSED_RESULT
+ vm_mmap(NULL, 0, PAGE_SIZE, PROT_READ | PROT_EXEC,
MAP_FIXED | MAP_PRIVATE, 0);
}
--- a/include/linux/compiler_attributes.h
+++ b/include/linux/compiler_attributes.h
@@ -284,6 +284,10 @@
* clang: https://clang.llvm.org/docs/AttributeReference.html#nodiscard-warn-unused-result
*/
#define __must_check __attribute__((__warn_unused_result__))
+/*
+ * "(void)" is enough for clang but not for gcc.
+ */
+#define SUPPRESS_WARN_UNUSED_RESULT (void)!
/*
* gcc: https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html#index-weak-function-attribute
next prev parent reply other threads:[~2021-06-25 21:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-25 19:52 [PATCH] ELF: add and use SUPRESS_WARN_UNUSED_RESULT Alexey Dobriyan
2021-06-25 20:34 ` Miguel Ojeda
2021-06-25 21:10 ` Alexey Dobriyan
2021-06-25 21:11 ` Randy Dunlap
2021-06-25 21:57 ` Miguel Ojeda
2021-06-26 6:44 ` [PATCH] ELF: add and use SUPRESS_WARN_UNUSED_RESULT\ Alexey Dobriyan
2021-06-26 14:29 ` Miguel Ojeda
2021-06-25 21:13 ` Alexey Dobriyan [this message]
2021-06-25 23:30 ` [PATCH v2] ELF: add and use SUPPRESS_WARN_UNUSED_RESULT Andrew Morton
2021-06-26 2:05 ` Linus Torvalds
2021-06-26 2:37 ` Al Viro
2021-06-26 3:13 ` Linus Torvalds
2021-06-26 6:40 ` Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNZG6N0W/7gjG7Gm@localhost.localdomain \
--to=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).