From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95954C49EAB for ; Fri, 25 Jun 2021 22:35:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7CCA86193D for ; Fri, 25 Jun 2021 22:35:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230032AbhFYWiD (ORCPT ); Fri, 25 Jun 2021 18:38:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52576 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229962AbhFYWiC (ORCPT ); Fri, 25 Jun 2021 18:38:02 -0400 Received: from mail-ot1-x32c.google.com (mail-ot1-x32c.google.com [IPv6:2607:f8b0:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0AC8BC061766 for ; Fri, 25 Jun 2021 15:35:40 -0700 (PDT) Received: by mail-ot1-x32c.google.com with SMTP id t4-20020a9d66c40000b029045e885b18deso10947683otm.6 for ; Fri, 25 Jun 2021 15:35:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Pmb7A01MDINvz8d62rv5mg4RMeGlJ/Hx32Z2jgV+wqk=; b=cXEESSsQgJyck9X1v4UqP/S0l+M78TCVpfxCtDuXB6Ux/dBggrsUW++2aCUYriTgnA UVz/x9Vc5RgmYJTOgdQvyI50meELS+ASvBEyo0LBJRFBcwj2n3kOR6EyV10gHowVggFI AdNPEca/2HGTQO+fPYgk21EQ6ohPgYi6BiqmazufPdVutgPpk+QJ0kv63iR/5KqywUfE mJdGhn7WGUcFvSE4U5MMUe9oVx+0pjBb7u4f2fwWMm3VS1BDnmDMUsvV0aN1K5SKv/yP cDT+a/AxWHfdmayQea8SVWbN+LpKl68G+Ox2psGXLfaw2vSqUtZMjaTgrjGZecBejfJ0 e/Tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Pmb7A01MDINvz8d62rv5mg4RMeGlJ/Hx32Z2jgV+wqk=; b=sbQKixLi5GJR6JpfZHd32g1MohimO/tsbQ8TUOqF9rw6ZmB6gJD7jomvS04uPSi42S ucMFJM25V/qnWLK4mia8QLmYyiG58358GnOGoOi2nM/cG0hPXdmPgu/4rTiQvryEHN7B L6J8WLu/AuYKdkJ4OPwkuA9BIooEon7Ao5Xvbz/rYTipJziYgb4+S8L3NF/oaxn77Mip otIJ3TfyHR13LLdIkG0SWcheuwkF7sH6SuYAbQ1KZb2q+zWbKT8ktE07UC7oaCo2wNML /IdB5naG7EvTncVYy2+hv6iSEXbXXT+Ocy1eoJb9DmrYYy2Bh5plMxllbKoThZEg6VOj 79Aw== X-Gm-Message-State: AOAM530x96kcyYg3GtMb+XI0xoptDgj9kSYJfloaTiXGsenRFge8rgrm 6hCmfLwJgLkZbLs57ASBv/7NDw== X-Google-Smtp-Source: ABdhPJxMZ9tt+AX/ZsFHAh/p7FuunQL7BgYsQ5AY02kgrgK6dxeia6d8tpoxS6EUCKQjMaLbi1Hezg== X-Received: by 2002:a05:6830:2415:: with SMTP id j21mr11489395ots.224.1624660539393; Fri, 25 Jun 2021 15:35:39 -0700 (PDT) Received: from yoga (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id y6sm1638129oiy.18.2021.06.25.15.35.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Jun 2021 15:35:38 -0700 (PDT) Date: Fri, 25 Jun 2021 17:35:36 -0500 From: Bjorn Andersson To: Bhupesh Sharma Cc: linux-arm-msm@vger.kernel.org, bhupesh.linux@gmail.com, balbi@kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, robh+dt@kernel.org, agross@kernel.org Subject: Re: [PATCH 1/2] arm64: dts: qcom: Use consistent naming for dwc3 usb nodes for sm8150 Message-ID: References: <20210625220311.527549-1-bhupesh.sharma@linaro.org> <20210625220311.527549-2-bhupesh.sharma@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210625220311.527549-2-bhupesh.sharma@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 25 Jun 17:03 CDT 2021, Bhupesh Sharma wrote: > The dwc3 usb nodes in sm8150.dtsi are currently named differently, > leading to some confusion when one sees the entries in sysfs or > dmesg: > [ 1.943482] dwc3 a600000.usb: Adding to iommu group 1 > [ 2.266127] dwc3 a800000.dwc3: Adding to iommu group 2 > > Name both the nodes as dwc3@ for consistency. > > While at it also arrange the two usb controller, hs-phy and > ss-phy nodes closer in the dts for better readability. > > Cc: Bjorn Andersson > Signed-off-by: Bhupesh Sharma > --- > arch/arm64/boot/dts/qcom/sm8150.dtsi | 30 ++++++++++++++-------------- > 1 file changed, 15 insertions(+), 15 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi > index 612dda0fef43..3be6d093a99b 100644 > --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi > @@ -2205,6 +2205,20 @@ glink-edge { > }; > }; > > + dc_noc: interconnect@9160000 { > + compatible = "qcom,sm8150-dc-noc"; > + reg = <0 0x09160000 0 0x3200>; > + #interconnect-cells = <1>; > + qcom,bcm-voters = <&apps_bcm_voter>; > + }; > + > + gem_noc: interconnect@9680000 { > + compatible = "qcom,sm8150-gem-noc"; > + reg = <0 0x09680000 0 0x3e200>; > + #interconnect-cells = <1>; > + qcom,bcm-voters = <&apps_bcm_voter>; > + }; > + > usb_1_hsphy: phy@88e2000 { > compatible = "qcom,sm8150-usb-hs-phy", > "qcom,usb-snps-hs-7nm-phy"; > @@ -2266,20 +2280,6 @@ usb_1_ssphy: lanes@88e9200 { > }; > }; > > - dc_noc: interconnect@9160000 { > - compatible = "qcom,sm8150-dc-noc"; > - reg = <0 0x09160000 0 0x3200>; > - #interconnect-cells = <1>; > - qcom,bcm-voters = <&apps_bcm_voter>; > - }; > - > - gem_noc: interconnect@9680000 { > - compatible = "qcom,sm8150-gem-noc"; > - reg = <0 0x09680000 0 0x3e200>; > - #interconnect-cells = <1>; > - qcom,bcm-voters = <&apps_bcm_voter>; > - }; > - > usb_2_qmpphy: phy@88eb000 { > compatible = "qcom,sm8150-qmp-usb3-uni-phy"; > reg = <0 0x088eb000 0 0x200>; > @@ -2344,7 +2344,7 @@ usb_1: usb@a6f8800 { > > resets = <&gcc GCC_USB30_PRIM_BCR>; > > - usb_1_dwc3: usb@a600000 { > + usb_1_dwc3: dwc3@a600000 { "usb@" is actually the right one, per the rather recent standardization across the dwc3 bindings. Regards, Bjorn > compatible = "snps,dwc3"; > reg = <0 0x0a600000 0 0xcd00>; > interrupts = ; > -- > 2.31.1 >