From: Al Viro <email@example.com> To: Linus Torvalds <firstname.lastname@example.org> Cc: Andrew Morton <email@example.com>, Alexey Dobriyan <firstname.lastname@example.org>, Linux Kernel Mailing List <email@example.com>, Miguel Ojeda <firstname.lastname@example.org> Subject: Re: [PATCH v2] ELF: add and use SUPPRESS_WARN_UNUSED_RESULT Date: Sat, 26 Jun 2021 02:37:24 +0000 [thread overview] Message-ID: <YNaS5AZDDpL3gJfe@zeniv-ca.linux.org.uk> (raw) In-Reply-To: <CAHk-=whVa=nm_GW=NVfPHqcxDbWt4JjjK1YWb0cLjO4ZSGyiDA@mail.gmail.com> On Fri, Jun 25, 2021 at 07:05:58PM -0700, Linus Torvalds wrote: > > Do we really care about userspace which relies upon an SVR4 quirk? I > > guess it's too hard to prove the no case, so it stays. > > I think we can safely remove it. Doing a mmap() at address zero will > not actually work anyway in any half-way modern Linux environment. > > And I think the "map zeroes at NULL" wasn't even universal for SVr4. > _Some_ binaries may have expected it, but I suspect it was the > exception rather than the rule. > > So I'd happily take a patch that just removes it. If nothing else, it > would be trivial to put back if somebody screams, but I seriously > doubt that is going to happen. Wasn't there some emulator (dosemu? wine?) that relied upon that? Said that, I could be easily wrong - half-asleep right now...
next prev parent reply other threads:[~2021-06-26 2:37 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-25 19:52 [PATCH] ELF: add and use SUPRESS_WARN_UNUSED_RESULT Alexey Dobriyan 2021-06-25 20:34 ` Miguel Ojeda 2021-06-25 21:10 ` Alexey Dobriyan 2021-06-25 21:11 ` Randy Dunlap 2021-06-25 21:57 ` Miguel Ojeda 2021-06-26 6:44 ` [PATCH] ELF: add and use SUPRESS_WARN_UNUSED_RESULT\ Alexey Dobriyan 2021-06-26 14:29 ` Miguel Ojeda 2021-06-25 21:13 ` [PATCH v2] ELF: add and use SUPPRESS_WARN_UNUSED_RESULT Alexey Dobriyan 2021-06-25 23:30 ` Andrew Morton 2021-06-26 2:05 ` Linus Torvalds 2021-06-26 2:37 ` Al Viro [this message] 2021-06-26 3:13 ` Linus Torvalds 2021-06-26 6:40 ` Alexey Dobriyan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YNaS5AZDDpL3gJfe@zeniv-ca.linux.org.uk \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH v2] ELF: add and use SUPPRESS_WARN_UNUSED_RESULT' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).