From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: rajeevny@codeaurora.org
Cc: dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
freedreno@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, thierry.reding@gmail.com,
sam@ravnborg.org, robdclark@gmail.com, dianders@chromium.org,
lyude@redhat.com, jani.nikula@intel.com, robh@kernel.org,
a.hajda@samsung.com, daniel.thompson@linaro.org,
hoegsberg@chromium.org, abhinavk@codeaurora.org,
seanpaul@chromium.org, kalyan_t@codeaurora.org,
mkrishn@codeaurora.org
Subject: Re: [v8 4/6] drm/panel-simple: Update validation warnings for eDP panel description
Date: Mon, 28 Jun 2021 16:33:29 +0300 [thread overview]
Message-ID: <YNnPqYjaZjmmrQTA@pendragon.ideasonboard.com> (raw)
In-Reply-To: <d75afefac48229657d36e12b6bac0e9f@codeaurora.org>
Hi Rajeev,
On Mon, Jun 28, 2021 at 05:46:24PM +0530, rajeevny@codeaurora.org wrote:
> On 27-06-2021 23:48, Laurent Pinchart wrote:
> > On Sat, Jun 26, 2021 at 10:21:06PM +0530, Rajeev Nandan wrote:
> >> Do not give a warning for the eDP panels if the "bus_format" is
> >> not specified, since most eDP panels can support more than one
> >> bus formats and this can be auto-detected.
> >> Also, update the check to include bpc=10 for the eDP panel.
> >>
> >> Signed-off-by: Rajeev Nandan <rajeevny@codeaurora.org>
> >> ---
> >>
> >> Changes in v8:
> >> - New patch, to address the review comments of Sam Ravnborg [1]
> >>
> >> [1]
> >> https://lore.kernel.org/dri-devel/20210621184157.GB918146@ravnborg.org/
> >>
> >> drivers/gpu/drm/panel/panel-simple.c | 6 ++----
> >> 1 file changed, 2 insertions(+), 4 deletions(-)
> >>
> >> diff --git a/drivers/gpu/drm/panel/panel-simple.c
> >> b/drivers/gpu/drm/panel/panel-simple.c
> >> index 86e5a45..f966b562 100644
> >> --- a/drivers/gpu/drm/panel/panel-simple.c
> >> +++ b/drivers/gpu/drm/panel/panel-simple.c
> >> @@ -772,10 +772,8 @@ static int panel_simple_probe(struct device *dev,
> >> const struct panel_desc *desc,
> >> desc->bpc != 8);
> >> break;
> >> case DRM_MODE_CONNECTOR_eDP:
> >> - if (desc->bus_format == 0)
> >> - dev_warn(dev, "Specify missing bus_format\n");
> >> - if (desc->bpc != 6 && desc->bpc != 8)
> >> - dev_warn(dev, "Expected bpc in {6,8} but got: %u\n", desc->bpc);
> >> + if (desc->bpc != 6 && desc->bpc != 8 && desc->bpc != 10)
> >> + dev_warn(dev, "Expected bpc in {6,8,10} but got: %u\n", desc->bpc);
> >
> > You'll still get a warning is bpc == 0, is that intentional ?
>
> This was not intentional, I missed considering bpc=0 case. As we are
> removing the warning for bus_format=0 then a similar thing can be done
> for the bpc=0 also. The bpc value should be a valid one if it is
> specified. Unlike the bus_format, bpc has few possible values that can
> be checked here along with 0. Please correct me if I misunderstood the
> concept.
> I will fix this.
What's the point of specifying bpc if it's optional though ? Users of
the panel will need to support the case where bpc is set to 0. Have you
ensured that they all do ? Can they meaningfully use the bpc value if
they need to be ready to support bpc == 0 ?
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2021-06-28 13:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-26 16:51 [v8 0/6] drm: Support basic DPCD backlight in panel-simple and add a new panel ATNA33XC20 Rajeev Nandan
2021-06-26 16:51 ` [v8 1/6] drm/panel: add basic DP AUX backlight support Rajeev Nandan
2021-07-12 9:41 ` Thomas Zimmermann
2021-07-12 9:45 ` Thomas Zimmermann
2021-07-12 13:39 ` Doug Anderson
2021-07-12 15:03 ` Doug Anderson
2021-06-26 16:51 ` [v8 2/6] drm/panel-simple: Support DP AUX backlight Rajeev Nandan
2021-06-26 16:51 ` [v8 3/6] drm/panel-simple: Support for delays between GPIO & regulator Rajeev Nandan
2021-06-26 16:51 ` [v8 4/6] drm/panel-simple: Update validation warnings for eDP panel description Rajeev Nandan
2021-06-27 18:18 ` Laurent Pinchart
2021-06-28 12:16 ` rajeevny
2021-06-28 13:33 ` Laurent Pinchart [this message]
2021-06-28 15:34 ` Doug Anderson
2021-06-28 16:25 ` Laurent Pinchart
2021-06-26 16:51 ` [v8 5/6] dt-bindings: display: simple: Add Samsung ATNA33XC20 Rajeev Nandan
2021-06-26 16:51 ` [v8 6/6] drm/panel-simple: " Rajeev Nandan
2021-07-09 13:54 ` [v8 0/6] drm: Support basic DPCD backlight in panel-simple and add a new panel ATNA33XC20 Doug Anderson
2021-07-09 20:40 ` Ville Syrjälä
2021-07-09 22:31 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNnPqYjaZjmmrQTA@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=abhinavk@codeaurora.org \
--cc=daniel.thompson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=hoegsberg@chromium.org \
--cc=jani.nikula@intel.com \
--cc=kalyan_t@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=mkrishn@codeaurora.org \
--cc=rajeevny@codeaurora.org \
--cc=robdclark@gmail.com \
--cc=robh@kernel.org \
--cc=sam@ravnborg.org \
--cc=seanpaul@chromium.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).