[PATCH] misc/pvpanic-pci: Allow automatic loading

[PATCH] misc/pvpanic-pci: Allow automatic loading

[Eric Auger]

The pvpanic-pci driver does not auto-load and requires manual
modprobe. Let's include a device database using the
MODULE_DEVICE_TABLE macro.

Signed-off-by: Eric Auger <eric.auger@redhat.com>
---
 drivers/misc/pvpanic/pvpanic-pci.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/misc/pvpanic/pvpanic-pci.c b/drivers/misc/pvpanic/pvpanic-pci.c
index 9ecc4e8559d5d..30290d42d8aa8 100644
--- a/drivers/misc/pvpanic/pvpanic-pci.c
+++ b/drivers/misc/pvpanic/pvpanic-pci.c
@@ -122,4 +122,6 @@ static struct pci_driver pvpanic_pci_driver = {
 	},
 };
 
+MODULE_DEVICE_TABLE(pci, pvpanic_pci_id_tbl);
+
 module_pci_driver(pvpanic_pci_driver);
-- 
2.26.3

Re: [PATCH] misc/pvpanic-pci: Allow automatic loading

[Greg KH]

On Mon, Jun 28, 2021 at 04:44:22PM +0200, Eric Auger wrote:
> The pvpanic-pci driver does not auto-load and requires manual
> modprobe. Let's include a device database using the
> MODULE_DEVICE_TABLE macro.
> 
> Signed-off-by: Eric Auger <eric.auger@redhat.com>
> ---
>  drivers/misc/pvpanic/pvpanic-pci.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/misc/pvpanic/pvpanic-pci.c b/drivers/misc/pvpanic/pvpanic-pci.c
> index 9ecc4e8559d5d..30290d42d8aa8 100644
> --- a/drivers/misc/pvpanic/pvpanic-pci.c
> +++ b/drivers/misc/pvpanic/pvpanic-pci.c
> @@ -122,4 +122,6 @@ static struct pci_driver pvpanic_pci_driver = {
>  	},
>  };
>  
> +MODULE_DEVICE_TABLE(pci, pvpanic_pci_id_tbl);
> +

Is this something that you need?  Or is it created by a tool?

thanks,

greg k-h

Re: [PATCH] misc/pvpanic-pci: Allow automatic loading

[Eric Auger]

Hi Greg,

On 6/28/21 4:54 PM, Greg KH wrote:
> On Mon, Jun 28, 2021 at 04:44:22PM +0200, Eric Auger wrote:
>> The pvpanic-pci driver does not auto-load and requires manual
>> modprobe. Let's include a device database using the
>> MODULE_DEVICE_TABLE macro.
>>
>> Signed-off-by: Eric Auger <eric.auger@redhat.com>
>> ---
>>  drivers/misc/pvpanic/pvpanic-pci.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/misc/pvpanic/pvpanic-pci.c b/drivers/misc/pvpanic/pvpanic-pci.c
>> index 9ecc4e8559d5d..30290d42d8aa8 100644
>> --- a/drivers/misc/pvpanic/pvpanic-pci.c
>> +++ b/drivers/misc/pvpanic/pvpanic-pci.c
>> @@ -122,4 +122,6 @@ static struct pci_driver pvpanic_pci_driver = {
>>  	},
>>  };
>>  
>> +MODULE_DEVICE_TABLE(pci, pvpanic_pci_id_tbl);
>> +
> Is this something that you need?  Or is it created by a tool?

the virtual machine monitor (QEMU) exposes the pvpanic-pci device to the
guest. On guest side the module exists but currently isn't loaded
automatically. So the driver fails to be probed and does not its job of
handling guest panic events. We need a SW actor that loads the module
and I thought this should be handled that way. If not, please could you
advise?

Thank you in advance

Eric 
>
> thanks,
>
> greg k-h
>

Re: [PATCH] misc/pvpanic-pci: Allow automatic loading

[Andy Shevchenko]

On Mon, Jun 28, 2021 at 05:44:13PM +0200, Eric Auger wrote:
> On 6/28/21 4:54 PM, Greg KH wrote:
> > On Mon, Jun 28, 2021 at 04:44:22PM +0200, Eric Auger wrote:
> >> The pvpanic-pci driver does not auto-load and requires manual
> >> modprobe. Let's include a device database using the
> >> MODULE_DEVICE_TABLE macro.

...

> > Is this something that you need?  Or is it created by a tool?
> 
> the virtual machine monitor (QEMU) exposes the pvpanic-pci device to the
> guest. On guest side the module exists but currently isn't loaded
> automatically. So the driver fails to be probed and does not its job of
> handling guest panic events. We need a SW actor that loads the module
> and I thought this should be handled that way. If not, please could you
> advise?

At least something like about should have been in the commit message.
Otherwise the selling point is unclear.

-- 
With Best Regards,
Andy Shevchenko