From: Petr Mladek <pmladek@suse.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Tanner Love <tannerlove.kernel@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Mahesh Bandewar <maheshb@google.com>,
"Darrick J . Wong" <djwong@kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
John Ogness <john.ogness@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Jakub Kicinski <kuba@kernel.org>,
Andrii Nakryiko <andriin@fb.com>,
Antoine Tenart <atenart@kernel.org>,
Alexander Lobakin <alobakin@pm.me>, Wei Wang <weiwan@google.com>,
Taehee Yoo <ap420073@gmail.com>,
Yunsheng Lin <linyunsheng@huawei.com>,
Willem de Bruijn <willemb@google.com>,
Tanner Love <tannerlove@google.com>
Subject: Re: [PATCH net-next v3 1/2] once: implement DO_ONCE_LITE for non-fast-path "do once" functionality
Date: Tue, 29 Jun 2021 09:33:42 +0200 [thread overview]
Message-ID: <YNrM1neBRdjkRf02@alley> (raw)
In-Reply-To: <20210628111446.357b2418@oasis.local.home>
On Mon 2021-06-28 11:14:46, Steven Rostedt wrote:
> On Mon, 28 Jun 2021 09:50:06 -0400
> Tanner Love <tannerlove.kernel@gmail.com> wrote:
>
> > Certain uses of "do once" functionality reside outside of fast path,
> > and so do not require jump label patching via static keys, making
> > existing DO_ONCE undesirable in such cases.
> >
> > Replace uses of __section(".data.once") with DO_ONCE_LITE(_IF)?
>
> I hate the name "_LITE" but can't come up with something better.
>
> Maybe: DO_ONCE_SLOW() ??
Or rename the original DO_ONCE() to DO_ONCE_FAST() because it is
more tricky to be fast. And call the "normal" implementation DO_ONCE().
> Anyway, besides my bike-shedding comment above...
Same here :-)
Acked-by: Petr Mladek <pmladek@suse.com>
Best Regards,
Petr
next prev parent reply other threads:[~2021-06-29 7:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-28 13:50 [PATCH net-next v3 0/2] net: update netdev_rx_csum_fault() print dump only once Tanner Love
2021-06-28 13:50 ` [PATCH net-next v3 1/2] once: implement DO_ONCE_LITE for non-fast-path "do once" functionality Tanner Love
2021-06-28 15:14 ` Steven Rostedt
2021-06-29 7:33 ` Petr Mladek [this message]
2021-06-28 13:50 ` [PATCH net-next v3 2/2] net: update netdev_rx_csum_fault() print dump only once Tanner Love
2021-06-28 23:10 ` [PATCH net-next v3 0/2] " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNrM1neBRdjkRf02@alley \
--to=pmladek@suse.com \
--cc=alobakin@pm.me \
--cc=andriin@fb.com \
--cc=ap420073@gmail.com \
--cc=arnd@arndb.de \
--cc=atenart@kernel.org \
--cc=davem@davemloft.net \
--cc=djwong@kernel.org \
--cc=edumazet@google.com \
--cc=john.ogness@linutronix.de \
--cc=kuba@kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linyunsheng@huawei.com \
--cc=maheshb@google.com \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=tannerlove.kernel@gmail.com \
--cc=tannerlove@google.com \
--cc=weiwan@google.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).