From: Tony Lindgren <tony@atomide.com> To: Mike Rapoport <rppt@linux.ibm.com> Cc: Mike Rapoport <rppt@kernel.org>, linux-arm-kernel@lists.infradead.org, Andrew Morton <akpm@linux-foundation.org>, Kefeng Wang <wangkefeng.wang@huawei.com>, Russell King <linux@armlinux.org.uk>, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-omap@vger.kernel.org, regressions@lists.linux.dev Subject: Re: [PATCH v2 3/3] arm: extend pfn_valid to take into accound freed memory map alignment Date: Tue, 29 Jun 2021 11:54:02 +0300 [thread overview] Message-ID: <YNrfqtBpKsNj033w@atomide.com> (raw) In-Reply-To: <YNqwl8EPVYZJV0EF@linux.ibm.com> Hi, * Mike Rapoport <rppt@linux.ibm.com> [210629 05:33]: > On Mon, Jun 28, 2021 at 06:26:26PM +0300, Tony Lindgren wrote: > > * Mike Rapoport <rppt@linux.ibm.com> [210628 14:07]: > > > Can you please send log with 'memblock=debug' added to the command line? > > > > Sure, log now available at: > > > > http://muru.com/beagle-x15.txt > > Hmm, no clues yet :( > > Do you have CONFIG_DEBUG_VM, CONFIG_DEBUG_VM_PGFLAGS and > CONFIG_PAGE_POISONING enabled in your config? > If not, can you please enable them and see if any of VM_BUG_* triggers? OK enabled, and no errors or warnings are triggered. > Do you use FLATMEM or SPARSEMEM in your config? Looks like make omap2plus_defconfig enables FLATMEM: $ grep -e SPARSEMEM -e FLATMEM .config CONFIG_ARCH_FLATMEM_ENABLE=y CONFIG_ARCH_SPARSEMEM_ENABLE=y CONFIG_FLATMEM_MANUAL=y # CONFIG_SPARSEMEM_MANUAL is not set CONFIG_FLATMEM=y > Let's try seeing what PFNs get false results from pfn_valid, maybe this > will give a better lead. With your patch below, system boots with lots of the following: [ 13.058654] Freeing unused kernel image (initmem) memory: 1024K ... [ 13.129211] pfn_valid(__sync_icache_dcache+0x2c/0x138): pfn: fffb6: is_map: 1 overlaps: 0 [ 13.137481] pfn_valid(__sync_icache_dcache+0x2c/0x138): pfn: fffb7: is_map: 1 overlaps: 0 [ 13.145751] pfn_valid(__sync_icache_dcache+0x2c/0x138): pfn: fffb8: is_map: 1 overlaps: 0 [ 13.153991] pfn_valid(__sync_icache_dcache+0x2c/0x138): pfn: fffb9: is_map: 1 overlaps: 0 [ 13.162200] pfn_valid(__sync_icache_dcache+0x2c/0x138): pfn: fffba: is_map: 1 overlaps: 0 [ 13.170440] pfn_valid(__sync_icache_dcache+0x2c/0x138): pfn: fffbb: is_map: 1 overlaps: 0 [ 13.178680] pfn_valid(__sync_icache_dcache+0x2c/0x138): pfn: fffbc: is_map: 1 overlaps: 0 [ 13.186920] pfn_valid(__sync_icache_dcache+0x2c/0x138): pfn: fffbd: is_map: 1 overlaps: 0 [ 13.195159] pfn_valid(__sync_icache_dcache+0x2c/0x138): pfn: fffbe: is_map: 1 overlaps: 0 [ 13.203399] pfn_valid(__sync_icache_dcache+0x2c/0x138): pfn: fffbf: is_map: 1 overlaps: 0 [ 13.211639] pfn_valid(__sync_icache_dcache+0x2c/0x138): pfn: fff00: is_map: 1 overlaps: 0 ... Then changing console loglevel to 0 boots system to login prompt. But I'm seeing some init processes segfaulting during start-up. Regards, Tony > diff --git a/arch/arm/mm/init.c b/arch/arm/mm/init.c > index 6162a070a410..66985fc3e730 100644 > --- a/arch/arm/mm/init.c > +++ b/arch/arm/mm/init.c > @@ -126,10 +126,16 @@ int pfn_valid(unsigned long pfn) > { > phys_addr_t addr = __pfn_to_phys(pfn); > unsigned long pageblock_size = PAGE_SIZE * pageblock_nr_pages; > + bool overlaps = memblock_overlaps_region(&memblock.memory, > + ALIGN_DOWN(addr, pageblock_size), > + pageblock_size); > > if (__phys_to_pfn(addr) != pfn) > return 0; > > + if (memblock_is_map_memory(addr) != overlaps) > + pr_info("%s(%pS): pfn: %lx: is_map: %d overlaps: %d\n", __func__, (void *)_RET_IP_, pfn, memblock_is_map_memory(addr), overlaps); > + > /* > * If address less than pageblock_size bytes away from a present > * memory chunk there still will be a memory map entry for it > > -- > Sincerely yours, > Mike.
next prev parent reply other threads:[~2021-06-29 8:54 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-19 14:14 [PATCH v2 0/3] memblock, arm: fixes for freeing of the memory map Mike Rapoport 2021-05-19 14:14 ` [PATCH v2 1/3] memblock: free_unused_memmap: use pageblock units instead of MAX_ORDER Mike Rapoport 2021-05-19 14:14 ` [PATCH v2 2/3] memblock: align freed memory map on pageblock boundaries with SPARSEMEM Mike Rapoport 2021-05-19 14:14 ` [PATCH v2 3/3] arm: extend pfn_valid to take into accound freed memory map alignment Mike Rapoport 2021-06-28 10:20 ` Tony Lindgren 2021-06-28 13:16 ` Mike Rapoport 2021-06-28 15:26 ` Tony Lindgren 2021-06-29 5:33 ` Mike Rapoport 2021-06-29 8:54 ` Tony Lindgren [this message] 2021-06-29 10:50 ` Mike Rapoport 2021-06-29 11:52 ` Tony Lindgren 2021-06-29 12:50 ` Mike Rapoport 2021-06-29 12:53 ` Tony Lindgren 2021-06-30 7:20 ` Mike Rapoport 2021-05-20 6:21 ` [PATCH v2 0/3] memblock, arm: fixes for freeing of the memory map Kefeng Wang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YNrfqtBpKsNj033w@atomide.com \ --to=tony@atomide.com \ --cc=akpm@linux-foundation.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=linux-omap@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=regressions@lists.linux.dev \ --cc=rppt@kernel.org \ --cc=rppt@linux.ibm.com \ --cc=wangkefeng.wang@huawei.com \ --subject='Re: [PATCH v2 3/3] arm: extend pfn_valid to take into accound freed memory map alignment' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).