From: Christoph Hellwig <hch@infradead.org>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: axboe@kernel.dk, hare@suse.de, bvanassche@acm.org,
ming.lei@redhat.com, hch@infradead.org, jack@suse.cz,
osandov@fb.com, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/6] block: move disk announce work from register_disk() to a helper
Date: Thu, 15 Jul 2021 08:16:59 +0100 [thread overview]
Message-ID: <YO/g69V42uqtbeJ5@infradead.org> (raw)
In-Reply-To: <YO/eRW4VL1UFlNS5@infradead.org>
On Thu, Jul 15, 2021 at 08:05:41AM +0100, Christoph Hellwig wrote:
> On Wed, Jul 14, 2021 at 09:55:27PM -0700, Luis Chamberlain wrote:
> > This moves quite a bit of code which does one thing into a helper.
> > We currently do not check for errors but we may decide that might
> > be desirable later.
> >
> > This also makes the code easier to read.
> >
> > This change has no functional changes.
>
> On it's own I don't really see the point of moving two function
> calls and a comment into a separate helper, but I'll see where this
> series goes..
Looking at the whole context I still can't see a good reason for
this helper.
next prev parent reply other threads:[~2021-07-15 7:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-15 4:55 [PATCH v2 0/6] block: add error handling for *add_disk*() Luis Chamberlain
2021-07-15 4:55 ` [PATCH v2 1/6] block: refcount the request_queue early in __device_add_disk() Luis Chamberlain
2021-07-15 7:02 ` Christoph Hellwig
2021-07-15 4:55 ` [PATCH v2 2/6] block: move disk announce work from register_disk() to a helper Luis Chamberlain
2021-07-15 7:05 ` Christoph Hellwig
2021-07-15 7:16 ` Christoph Hellwig [this message]
2021-07-15 4:55 ` [PATCH v2 3/6] block: move disk invalidation from del_gendisk() into " Luis Chamberlain
2021-07-15 7:46 ` Christoph Hellwig
2021-07-15 4:55 ` [PATCH v2 4/6] block: move disk unregistration work from del_gendisk() to " Luis Chamberlain
2021-07-15 4:55 ` [PATCH v2 5/6] block: add initial error handling for *add_disk()* and friends Luis Chamberlain
2021-07-15 7:57 ` Christoph Hellwig
2021-07-15 4:55 ` [PATCH v2 6/6] block: skip queue if NULL on blk_cleanup_queue() Luis Chamberlain
2021-07-15 7:11 ` Christoph Hellwig
2021-07-15 19:07 ` Luis Chamberlain
2021-07-19 9:50 ` Christoph Hellwig
2021-07-19 23:00 ` Luis Chamberlain
2021-07-15 7:23 ` [PATCH v2 0/6] block: add error handling for *add_disk*() Christoph Hellwig
2021-07-15 19:34 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YO/g69V42uqtbeJ5@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=hare@suse.de \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=ming.lei@redhat.com \
--cc=osandov@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).