linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joerg Roedel <joro@8bytes.org>
To: Frank Wunderlich <linux@fw-web.de>
Cc: iommu@lists.linux-foundation.org,
	Frank Wunderlich <frank-w@public-files.de>,
	Will Deacon <will@kernel.org>,
	linux-kernel@vger.kernel.org, yong.wu@mediatek.com
Subject: Re: [PATCH] iommu: check if group is NULL before remove device
Date: Thu, 15 Jul 2021 09:20:04 +0200	[thread overview]
Message-ID: <YO/hpPpu6Z526+Ia@8bytes.org> (raw)
In-Reply-To: <20210715071150.82157-1-linux@fw-web.de>

On Thu, Jul 15, 2021 at 09:11:50AM +0200, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
> 
> if probe is failing, iommu_group may be not initialized,

Sentences start with capital letters.

IOMMU patch subjects too, after the 'iommu:' prefix.

> so freeing it will result in NULL pointer access

Please describe in more detail how this NULL-ptr dereference is
triggered.

Regards,

	Joerg

  reply	other threads:[~2021-07-15  7:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-15  7:11 Frank Wunderlich
2021-07-15  7:20 ` Joerg Roedel [this message]
2021-07-28 10:35   ` Frank Wunderlich
2021-07-30 13:18   ` Frank Wunderlich (linux)
  -- strict thread matches above, loose matches on Subject: below --
2021-07-15  7:10 Frank Wunderlich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YO/hpPpu6Z526+Ia@8bytes.org \
    --to=joro@8bytes.org \
    --cc=frank-w@public-files.de \
    --cc=iommu@lists.linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@fw-web.de \
    --cc=will@kernel.org \
    --cc=yong.wu@mediatek.com \
    --subject='Re: [PATCH] iommu: check if group is NULL before remove device' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).