From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DA33C07E95 for ; Tue, 13 Jul 2021 20:39:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4658261362 for ; Tue, 13 Jul 2021 20:39:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235159AbhGMUmC (ORCPT ); Tue, 13 Jul 2021 16:42:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44436 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231499AbhGMUmB (ORCPT ); Tue, 13 Jul 2021 16:42:01 -0400 Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12715C0613DD for ; Tue, 13 Jul 2021 13:39:11 -0700 (PDT) Received: by mail-pj1-x1035.google.com with SMTP id p9so12785387pjl.3 for ; Tue, 13 Jul 2021 13:39:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=vAEz6tbBq7rYrMMnkx41TwsKhbqefEUfL96yExQSeis=; b=vXnVzvAmDrRF8FTIsxLeNffuHPTEaCiYb4YtzDpnJgAQPgXvS5lawhS8/WpTLy6Vo8 XlS/V+9queLMhMPiBN3DLqU2fxswvlBmwcLsjpD2m5ckBzHUhDYMteAj2jmdG4vTJfog NU5w6EgdvzWFrdlyYRIGFeE75quGdFyU8yJBd214cGiixfntXOFbiMbPSCeRXmpB4Kvw eF95YGDWecVO/K9fGyUaoAhWC/2xHXoluwTYXaQqEmoEywCIGKTh01ebamJj6d05BlT8 2Q7lSXC0DvKkNpfCZb/zgF0QjpTWOs5uzuEdlE8SsZJg2Z97Y0tQ9ph7APv7V+7TkLMh L0ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=vAEz6tbBq7rYrMMnkx41TwsKhbqefEUfL96yExQSeis=; b=iWN026RFsYHFG5P+95MPmNKdtFsM+zQ+pmi9OM79vwl7pOpqF89PoAjdDxtHtgVBVg ryOeTwXYmrXXLXqWYa9rAexgllWPRCn3nEyFsBXZvMgXnc7qPHGeb3u551cIaPnldgiU AkscnUW34wed/yeCqC1zDdWGJ25hvpIS/ipwbGvFw2Eh4hGfF+SXH8IHLkmPPzJgFEnB N1zcgVBYNKu+NFtaitpEOT7VYSA0B3ouZ4yuGytEv78mOcas/BmvfNdea8X0Nd+5RR2U njEZ3d6J8oK1tp0MyQXCS8bc9R1ideaY+Jmro5JLGb9gegfS1jynj+0YURvi0sAexrhS CdqA== X-Gm-Message-State: AOAM532L/fYJjaa2yO98/ZDQNigm/Pt8aNoM1frDvCMpABkK2xkapn2p /0Qqowwb0VnRCbVtTQl8GUZOHQ== X-Google-Smtp-Source: ABdhPJxKaCTzakoran7rQmGGw8tLT/Er02SRPgN8R/aU28R0uj21uUB5p9Z0RNISuFUJlrAIQ3rCSg== X-Received: by 2002:a17:90a:1785:: with SMTP id q5mr99843pja.38.1626208750366; Tue, 13 Jul 2021 13:39:10 -0700 (PDT) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id d29sm37603pfq.193.2021.07.13.13.39.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jul 2021 13:39:09 -0700 (PDT) Date: Tue, 13 Jul 2021 20:39:06 +0000 From: Sean Christopherson To: Paolo Bonzini Cc: isaku.yamahata@intel.com, Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , erdemaktas@google.com, Connor Kuehl , x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, isaku.yamahata@gmail.com, Sean Christopherson , Xiaoyao Li Subject: Re: [RFC PATCH v2 22/69] KVM: x86: Add vm_type to differentiate legacy VMs from protected VMs Message-ID: References: <8eb87cd52a89d957af03f93a9ece5634426a7757.1625186503.git.isaku.yamahata@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 06, 2021, Paolo Bonzini wrote: > On 03/07/21 00:04, isaku.yamahata@intel.com wrote: > > struct kvm_arch { > > + unsigned long vm_type; > > Also why not just int or u8? Heh, because kvm_dev_ioctl_create_vm() takes an "unsigned long" for the type and it felt wrong to store it as something else. Storing it as a smaller field should be fine, I highly doubt we'll get to 256 types anytime soon :-) I think kvm_x86_ops.is_vm_type_supported() should take the full size though.