From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26430C07E95 for ; Tue, 13 Jul 2021 18:14:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F0A6461152 for ; Tue, 13 Jul 2021 18:14:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233634AbhGMSRc (ORCPT ); Tue, 13 Jul 2021 14:17:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229478AbhGMSRb (ORCPT ); Tue, 13 Jul 2021 14:17:31 -0400 Received: from mail-pg1-x531.google.com (mail-pg1-x531.google.com [IPv6:2607:f8b0:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D628C0613E9 for ; Tue, 13 Jul 2021 11:14:41 -0700 (PDT) Received: by mail-pg1-x531.google.com with SMTP id h4so22306684pgp.5 for ; Tue, 13 Jul 2021 11:14:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=qYLRuC1J401GJNPoirPCf0sUsfjE1s5mBPfucqVBo/o=; b=TemUpZC6DppCYmoiy4LOJWEQeqEKh09xAT6P4VzLXIMbauvxoS4EP330OrBhT+KMD8 cR2UVyVjCHceV7KPG7a9NZZmYbyYSNNWo475SwL++N6I4zXO9yWb6VASQns9WnzfMOFh bHOmRt1m1x3AWl7z7ZKkjnUYvtZBijxS76sM/rse9ZmiC4tDHj3JBMAKP7TwgtjAxjVn Xf7JqdMkTGH04bfp2wk+pGQ3QGL2Tjh7KcfaEciMt87JIcLooAuNboN9SqoujtPQpTeI OX+q/7+1EwbpEtAufvbfEpN5lwH2yQY3OLYOTHt6yHv4KeueUCfkzIhTGMNnAtOJtiw6 ZiUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=qYLRuC1J401GJNPoirPCf0sUsfjE1s5mBPfucqVBo/o=; b=S6YovX/ykLaRa+7hi7onHQ8TFUZwsfN0MSTTaCe1nMnlKgI1eVrFmwUwvVC9S4sXbt d2zdfFEm2ZtQ42IeBJMSXihlqgFXhy8/SUxnXutCUO/NE+f2PwXqFJrTFgvqcKRQehW2 CufuPGuc95BUx1w7anv/EMVJ06ZkQjgANA7RaeA4EnrlCda8GRVphfBNNNqT+A4RubPU nYEn9AicCAyOKyA011xdC7t9CVeNzdvPSH2XZ32g662YaIBJPgG5ObMPGNcgvpzIq/l9 BnoRoGOZPCltphSu8IwZewTxAbxDqNEv1PJLUf2MCOl55XJQsW8oR/PP4E+miJGSndSq iw8g== X-Gm-Message-State: AOAM531GeZMnQUnKfp2QTYkMnRJRMAfJnII9rljbVK9k4gRRsw6sxTVD cgdZ3K09izdhqbZa29NcTiofgg== X-Google-Smtp-Source: ABdhPJw025D+QHvSXH7m/XdthsugBc+I0Bqri4rgbbh9zByxwSwtsOJDy77eNp2z0ZK1gdsXdBMXIg== X-Received: by 2002:a63:5c1b:: with SMTP id q27mr5441771pgb.284.1626200081027; Tue, 13 Jul 2021 11:14:41 -0700 (PDT) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id x9sm109548pfd.100.2021.07.13.11.14.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jul 2021 11:14:40 -0700 (PDT) Date: Tue, 13 Jul 2021 18:14:37 +0000 From: Sean Christopherson To: Paolo Bonzini Cc: isaku.yamahata@intel.com, Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , erdemaktas@google.com, Connor Kuehl , x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, isaku.yamahata@gmail.com, Xiaoyao Li Subject: Re: [RFC PATCH v2 65/69] KVM: X86: Introduce initial_tsc_khz in struct kvm_arch Message-ID: References: <5f87f0b888555b52041a0fe32280adee0d563e63.1625186503.git.isaku.yamahata@intel.com> <792040b0-4463-d805-d14e-ba264a3f8bbf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <792040b0-4463-d805-d14e-ba264a3f8bbf@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 06, 2021, Paolo Bonzini wrote: > On 03/07/21 00:05, isaku.yamahata@intel.com wrote: > > From: Xiaoyao Li > > > > Introduce a per-vm variable initial_tsc_khz to hold the default tsc_khz > > for kvm_arch_vcpu_create(). > > > > This field is going to be used by TDX since TSC frequency for TD guest > > is configured at TD VM initialization phase. > > > > Signed-off-by: Xiaoyao Li > > Signed-off-by: Isaku Yamahata > > --- > > arch/x86/include/asm/kvm_host.h | 1 + > > arch/x86/kvm/x86.c | 3 ++- > > 2 files changed, 3 insertions(+), 1 deletion(-) > > So this means disabling TSC frequency scaling on TDX. Would it make sense > to delay VM creation to a separate ioctl, similar to KVM_ARM_VCPU_FINALIZE > (KVM_VM_FINALIZE)? There's an equivalent of that in the next mega-patch, the KVM_TDX_INIT_VM sub-ioctl of KVM_MEMORY_ENCRYPT_OP. The TSC frequency for the guest gets provided at that time.