From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA819C07E95 for ; Tue, 13 Jul 2021 19:59:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D030D6101D for ; Tue, 13 Jul 2021 19:59:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234776AbhGMUC0 (ORCPT ); Tue, 13 Jul 2021 16:02:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35478 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234726AbhGMUCZ (ORCPT ); Tue, 13 Jul 2021 16:02:25 -0400 Received: from mail-pg1-x531.google.com (mail-pg1-x531.google.com [IPv6:2607:f8b0:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 33773C0613E9 for ; Tue, 13 Jul 2021 12:59:34 -0700 (PDT) Received: by mail-pg1-x531.google.com with SMTP id u14so22507898pga.11 for ; Tue, 13 Jul 2021 12:59:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=9SPgIXBvjkfAbqOot3l6wN5sOGVWN6nhha+7R377UfE=; b=JQhqPF7//EXTXCduetcHMVlJhMLHgrbGPjeudiWjYHkiAsdbjzsH05Vm9vIaGTvCUI vfik0jHFgmmWlnBBem0oUT0VXvXjOBJfKypI5DIyDFZOqHIXDC09rs9Jx/eZ+uMIC2wn 27ZzlL6Dfe+IS0bfEMfO3RvmZfhgd2awr8Y61oMacP97e6DxHKxKC1qMLJuqsQkIiF7H P9Fws229mOuxA4IhDexwpR60/WFDwlNJ76IFEbacXcwul6NHM4gVJjJCRyD7LL0029Z4 121ZCDtdiYpX0tzKjXKFMSpMiaEw/u5XqqHwXo15SD1F1uqS2FD+/v4cl5eX9Kq9TXpp 1R+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=9SPgIXBvjkfAbqOot3l6wN5sOGVWN6nhha+7R377UfE=; b=hLGw6dRnoskjqB/RXQk7nyFzYrzQ19AKZf5h4ZjUJWEJ9pH8upm3tXC9ncc6ZGIJwo 6jq0CQ1Cpr19xVAB5y0I6bHiRhcppXqBUTrIFrKfXAXScLm5E5eqg2ecHuXc/4Y2iqYP hWwHKuoz2cw/Gdc7zMl4gh5QacBZol9uyBEOPqEhkfNbSEvtEyBJe/CY8HgA5R8dIhZa dq/r6/xnJUps9mW1B2NC50iI0FisIlm0FOL8GcuquiQnpPi75j0GnGRXgzFLexTiE39F 46XSUDWMvkSYSu4WfQsWOSX5pTIzhW2PkCZpaGwnpkyXVIx8TpgHgXMMjhpOirb/sg2f NKVg== X-Gm-Message-State: AOAM531YJIlZl1fQb8tOIprA6WkiNlrewf8iNkYDUxcHx0NXFVMxQSd1 KEiJ1j1B+eNsda85PNG7oc2U2Q== X-Google-Smtp-Source: ABdhPJxMglAaACW1oWqveOVZakLQI9MwJUjxgo3hoJTXj52HjMNPmQWHTYs9OEyDUNmvsCKGkgesJg== X-Received: by 2002:a65:6658:: with SMTP id z24mr5794920pgv.266.1626206373599; Tue, 13 Jul 2021 12:59:33 -0700 (PDT) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id x19sm20234905pfa.104.2021.07.13.12.59.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jul 2021 12:59:33 -0700 (PDT) Date: Tue, 13 Jul 2021 19:59:29 +0000 From: Sean Christopherson To: Paolo Bonzini Cc: isaku.yamahata@intel.com, Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , erdemaktas@google.com, Connor Kuehl , x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, isaku.yamahata@gmail.com, Sean Christopherson , Kai Huang , Xiaoyao Li Subject: Re: [RFC PATCH v2 09/69] KVM: TDX: Add C wrapper functions for TDX SEAMCALLs Message-ID: References: <96e4e50feee62f476f2dcf170d20f9267c7d7d6a.1625186503.git.isaku.yamahata@intel.com> <597dcaf4-19c0-3507-ebfa-e07cb32f784c@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <597dcaf4-19c0-3507-ebfa-e07cb32f784c@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 06, 2021, Paolo Bonzini wrote: > On 03/07/21 00:04, isaku.yamahata@intel.com wrote: > > +static inline u64 tdh_mng_addcx(hpa_t tdr, hpa_t addr) > > +{ > > + return seamcall(TDH_MNG_ADDCX, addr, tdr, 0, 0, 0, NULL); > > +} > > + > > Since you have wrappers anyway, I don't like having an extra macro level > just to remove the SEAMCALL_ prefix. It messes up editors that look up the > symbols. True. On the other hand, prefixing SEAMCALL_ over and over is tedious and adds a lot of noise. What if we drop SEAMCALL_ from the #defines? The prefix made sense when there was no additional namespace, e.g. instead of having a bare TDCREATE, but that's mostly a non-issue now that all the SEAMCALLs are namespaced with TDH_.