From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-21.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AE8CC07E98 for ; Sun, 4 Jul 2021 00:17:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 03AE061582 for ; Sun, 4 Jul 2021 00:17:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229818AbhGDATe (ORCPT ); Sat, 3 Jul 2021 20:19:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:53590 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229529AbhGDATd (ORCPT ); Sat, 3 Jul 2021 20:19:33 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 359CB61443; Sun, 4 Jul 2021 00:16:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625357819; bh=PPAPh8PB3Qid66l3SUdSzjh88YZamPtSAuWf0trnz2Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=P5xzEo6sSeADfmDQCXV/fKLBfMbZkI9/Vk+wpJVQA+AEPrR+e+d1DPXCG6Orki76F u9NxfL1g9CUqAD8bN15NnGmIYkhkfhD/RQQt3p249U2p8EKpsw8ipyb3pHEsHcjvI4 0yWPPuGKIgugwf2S8PWVPDdjPhI3MLaWpX1yhsYO8ayYxpeME/d2cnZWkffkKDLLlB w0SEl2fYPGDumsyikmt4pg2foHGPe3XbIxm9Pvjkoak9K2eDoXvs+3b3WfB1ZZ1wYK djU5OR8Sqmn49fkjNy6pvc2WvGzx+T0fDnfBNLLEhmehffTq6neMQWpnKM8T84IQ8x f7ujKJujd5qEA== Date: Sat, 3 Jul 2021 17:16:55 -0700 From: Nathan Chancellor To: Lecopzer Chen Cc: ndesaulniers@google.com, keescook@chromium.org, samitolvanen@google.com, linux-kbuild@vger.kernel.org, clang-built-linux@googlegroups.com, linux-kernel@vger.kernel.org, yj.chiang@mediatek.com, masahiroy@kernel.org, michal.lkml@markovi.net Subject: Re: [PATCH v3 2/2] Kbuild: lto: add make version checking Message-ID: References: <20210702032943.7865-1-lecopzer.chen@mediatek.com> <20210702032943.7865-3-lecopzer.chen@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210702032943.7865-3-lecopzer.chen@mediatek.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 02, 2021 at 11:29:43AM +0800, Lecopzer Chen wrote: > LTO with MODVERSIONS will fail in generating correct CRC because > the makefile rule doesn't work for make with version 3.8X.[1] > > Thus we need to check make version during selecting on LTO Kconfig. > and the suitable version should be 4.2(40200) which released in 2016[2]. > > [1] https://lore.kernel.org/lkml/20210616080252.32046-1-lecopzer.chen@mediatek.com/ > [2] https://ftp.gnu.org/gnu/make/ > Signed-off-by: Lecopzer Chen Reviewed-by: Nathan Chancellor > --- > arch/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/Kconfig b/arch/Kconfig > index 129df498a8e1..beee68149da8 100644 > --- a/arch/Kconfig > +++ b/arch/Kconfig > @@ -639,6 +639,7 @@ config HAS_LTO_CLANG > def_bool y > # Clang >= 11: https://github.com/ClangBuiltLinux/linux/issues/510 > depends on CC_IS_CLANG && CLANG_VERSION >= 110000 && LD_IS_LLD && AS_IS_LLVM > + depends on !MODVERSIONS || MAKE_VERSION >= 40200 > depends on $(success,$(NM) --help | head -n 1 | grep -qi llvm) > depends on $(success,$(AR) --help | head -n 1 | grep -qi llvm) > depends on ARCH_SUPPORTS_LTO_CLANG > -- > 2.18.0