From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 262FEC07E9A for ; Mon, 5 Jul 2021 07:48:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0C78D61260 for ; Mon, 5 Jul 2021 07:48:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230078AbhGEHuu (ORCPT ); Mon, 5 Jul 2021 03:50:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46880 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229884AbhGEHut (ORCPT ); Mon, 5 Jul 2021 03:50:49 -0400 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D1CABC061574; Mon, 5 Jul 2021 00:48:12 -0700 (PDT) Received: by mail-wm1-x32c.google.com with SMTP id l18-20020a1ced120000b029014c1adff1edso13353438wmh.4; Mon, 05 Jul 2021 00:48:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=SXbBPp2iS8nwSVm3yeB0A4lnvn/jOz20r+A/6pXUHHY=; b=K8KS25r0RHUrbbXW3XiToZgcpnEoMxthTUzc1et0doSyqpGURw6rN9YwfipD9F6CuL Is8DqkdKuvQcJf7ZaelDbb+eut3Ec8uLegYdq5+d/eYmBO/Pl4fHeXAzR9ErOFlMVcF4 FB2H2ELWS1sJf+S1nN+B3l9y3VEVkLeIHLDk10dcm4FLKlYqzGLpOgvB134B9/b2U/bi ojuo5MBMt3aKTwYes5IewmdskUhFMQc0gWJHHW1zDGTI1QZf7RJ2xaoSZGcCqhDrBraP ATo6vteW9N89mHO9GWkyluVbcXsO326VdWCz7J6gKq9sjKgz5juwI9Z7jzVt2T0l8x+T BqKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=SXbBPp2iS8nwSVm3yeB0A4lnvn/jOz20r+A/6pXUHHY=; b=YaryAMR2v3trHfK9UAvJFENQZu915K3W4A+57UAKnaQOHz9GovB1F+H+Q3fDlEHUIO O8XmScZwuLmnO2qBPQO/0yXN8qGVNwW530wavIdZ/As5eH8ruWymDZ+wpiYp8zbl0YXQ 8XsIhs9nt7W6n2R95iLzE2O7NapfWCBvXhE35pxrCMpKEkXD3iAccZkhrDNeZaMWU1u8 Flw2OHG+s5dh4sUGxcDgT9PAsT5GARrsO58SGcJamOVDQbIvN9BI5uhgJGD4aAT8Hq+n wCk1PGRqNSVgeT1hcplRhzBetr57VWVp0wpelFZ59wMEV18cqzpf3EsCqMmGUgBk5oKs ohMQ== X-Gm-Message-State: AOAM5320V99dkVKOsUP6srYRRmLrGRLx1pmzqMS+26utaS6b/iIzpJIG D8PXma9lB0TET6hoz0ZRzMg= X-Google-Smtp-Source: ABdhPJy6OJA4bmaOgopY9Tl8app1eKjIwf+NslUjIwcHRD1gJ9o0m+6u65c2eaKAsQ6yFou5vY0k6A== X-Received: by 2002:a7b:c417:: with SMTP id k23mr13561630wmi.87.1625471291570; Mon, 05 Jul 2021 00:48:11 -0700 (PDT) Received: from gmail.com (178-164-188-14.pool.digikabel.hu. [178.164.188.14]) by smtp.gmail.com with ESMTPSA id h14sm13181602wro.32.2021.07.05.00.48.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Jul 2021 00:48:11 -0700 (PDT) Sender: Ingo Molnar Date: Mon, 5 Jul 2021 09:48:09 +0200 From: Ingo Molnar To: Masami Hiramatsu Cc: Steven Rostedt , Josh Poimboeuf , X86 ML , Daniel Xu , linux-kernel@vger.kernel.org, bpf@vger.kernel.org, kuba@kernel.org, mingo@redhat.com, ast@kernel.org, Thomas Gleixner , Borislav Petkov , Peter Zijlstra , kernel-team@fb.com, yhs@fb.com, linux-ia64@vger.kernel.org, Abhishek Sagar , Andrii Nakryiko Subject: Re: [PATCH -tip v8 02/13] kprobes: treewide: Replace arch_deref_entry_point() with dereference_symbol_descriptor() Message-ID: References: <162399992186.506599.8457763707951687195.stgit@devnote2> <162399994018.506599.10332627573727646767.stgit@devnote2> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <162399994018.506599.10332627573727646767.stgit@devnote2> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Masami Hiramatsu wrote: > Replace arch_deref_entry_point() with dereference_symbol_descriptor() > because those are doing same thing. > > Signed-off-by: Masami Hiramatsu > Tested-by: Andrii Nakryik A better changelog: ~15 years ago kprobes grew the 'arch_deref_entry_point()' __weak function: 3d7e33825d87: ("jprobes: make jprobes a little safer for users") But this is just open-coded dereference_symbol_descriptor() in essence, and its obscure nature was causing bugs. Just use the real thing. Thanks, Ingo