From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Yunsheng Lin <linyunsheng@huawei.com>
Cc: davem@davemloft.net, kuba@kernel.org, mst@redhat.com,
jasowang@redhat.com, nickhu@andestech.com, green.hu@gmail.com,
deanbo422@gmail.com, akpm@linux-foundation.org,
yury.norov@gmail.com, ojeda@kernel.org, ndesaulniers@gooogle.com,
joe@perches.com, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next 0/2] refactor the ringtest testing for ptr_ring
Date: Mon, 5 Jul 2021 17:57:30 +0300 [thread overview]
Message-ID: <YOMd2q8Mf08+QVQ2@smile.fi.intel.com> (raw)
In-Reply-To: <c6844e2b-530f-14b2-0ec3-d47574135571@huawei.com>
On Mon, Jul 05, 2021 at 08:06:50PM +0800, Yunsheng Lin wrote:
> On 2021/7/5 17:56, Andy Shevchenko wrote:
> > On Mon, Jul 05, 2021 at 11:57:33AM +0800, Yunsheng Lin wrote:
> >> tools/include/* have a lot of abstract layer for building
> >> kernel code from userspace, so reuse or add the abstract
> >> layer in tools/include/ to build the ptr_ring for ringtest
> >> testing.
> >
> > ...
> >
> >> create mode 100644 tools/include/asm/cache.h
> >> create mode 100644 tools/include/asm/processor.h
> >> create mode 100644 tools/include/generated/autoconf.h
> >> create mode 100644 tools/include/linux/align.h
> >> create mode 100644 tools/include/linux/cache.h
> >> create mode 100644 tools/include/linux/slab.h
> >
> > Maybe somebody can change this to be able to include in-tree headers directly?
>
> If the above works, maybe the files in tools/include/* is not
> necessary any more, just use the in-tree headers to compile
> the user space app?
>
> Or I missed something here?
I don't know if it works or not or why that decision had been made to
copy'n'paste headers (Yes, I know they have some modifications).
Somebody needs to check that and see what can be done in order to avoid copying
entire include into tools/include.
> > Besides above, had you tested this with `make O=...`?
>
> You are right, the generated/autoconf.h is in another directory
> with `make O=...`.
>
> Any nice idea to fix the above problem?
No idea. But I consider breakage of O= is a show stopper.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-07-05 14:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-05 3:57 [PATCH net-next 0/2] refactor the ringtest testing for ptr_ring Yunsheng Lin
2021-07-05 3:57 ` [PATCH net-next 1/2] tools: add missing infrastructure for building ptr_ring.h Yunsheng Lin
2021-07-05 18:39 ` Michael S. Tsirkin
2021-07-06 2:04 ` Yunsheng Lin
2021-07-18 2:09 ` Michael S. Tsirkin
2021-07-19 1:40 ` Yunsheng Lin
2021-07-19 11:58 ` Michael S. Tsirkin
2021-07-05 3:57 ` [PATCH net-next 2/2] tools/virtio: use common infrastructure to build ptr_ring.h Yunsheng Lin
2021-07-05 9:56 ` [PATCH net-next 0/2] refactor the ringtest testing for ptr_ring Andy Shevchenko
2021-07-05 12:06 ` Yunsheng Lin
2021-07-05 14:57 ` Andy Shevchenko [this message]
2021-07-05 18:26 ` Michael S. Tsirkin
2021-07-05 18:36 ` Andy Shevchenko
2021-07-05 18:42 ` Michael S. Tsirkin
2021-07-05 19:05 ` Andy Shevchenko
2021-07-05 19:31 ` Michael S. Tsirkin
2021-07-06 1:35 ` Yunsheng Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YOMd2q8Mf08+QVQ2@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=deanbo422@gmail.com \
--cc=green.hu@gmail.com \
--cc=jasowang@redhat.com \
--cc=joe@perches.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linyunsheng@huawei.com \
--cc=mst@redhat.com \
--cc=ndesaulniers@gooogle.com \
--cc=netdev@vger.kernel.org \
--cc=nickhu@andestech.com \
--cc=ojeda@kernel.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).