From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30AAFC07E9C for ; Mon, 5 Jul 2021 20:34:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1798C6197F for ; Mon, 5 Jul 2021 20:34:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230000AbhGEUhJ (ORCPT ); Mon, 5 Jul 2021 16:37:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229959AbhGEUhI (ORCPT ); Mon, 5 Jul 2021 16:37:08 -0400 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8FF0DC06175F for ; Mon, 5 Jul 2021 13:34:30 -0700 (PDT) Received: by mail-wm1-x32a.google.com with SMTP id t14-20020a05600c198eb029020c8aac53d4so674222wmq.1 for ; Mon, 05 Jul 2021 13:34:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=+6XOS/q6tNEotrOvsPcxWCl8XfwpWQ06BCfh8JP8qiQ=; b=OZWxOeaAZD36E5pXxxm6Y4Pq5dMm4vQyq3XYuN9VI+P4x03ANViKySjMaKux1H2p6/ /tj52CZTWP9a5s2wQs25SXkMOxHxQIYmWsXj8WSn0ypX+TOosipox/szAKuNi6li+tzU VzBRRMSufdqzX+6b9avxM+vicqNSSkIe7I06jsY4XW24zwscdbDTvHoqK0sYi794z91G uLDsgYv8M8MahuMr80pccB74y1j+tHwc/gFIHQNf2uF+LRrj8BGGJQKxyOG+L2+ixhza UCS+I5ZF7QjJpArK8dN1aqXjlJ2Q758b4wDV7qCHuaLXq7FpM7hbMFfaz+VrMcm1XaaI SyVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=+6XOS/q6tNEotrOvsPcxWCl8XfwpWQ06BCfh8JP8qiQ=; b=WX5FjYbCIOZSRDai+OPYsh9lYrskQOgYkS7+bLfu54BMX0ZQNAipW4E9n3dwJjlypj WwFjkKVKn2qVRaiR4rqV5rwFxss10bbMdBWiMnzMZ6Hzcksw9ckxKYWJvm6Icydw8A8H VZblXPWKl0JrbcUsZKyQdQ0XXJxvR2yziYo2pnKwo55BsXooE/02Bobz1XjhWsPSS8k3 lt9bknz1MZ7+y6+b4Yi+TqxnxE1+6ZilUT2DFrw3fef2IKy30nVPGPp69NwBdeCanKX/ tD41HNpE82gfp0+N1ZDQA08Tj6GMvnlfp5VItJBL29Nvxyltz2PUNvFzf2OQLj3hxzav 2y3w== X-Gm-Message-State: AOAM532c5u4gSxbwQVAK1liFA0sYIB4huQ9ht7YF322FNahXu+SZ/xvW aHzLIbiLQEhu12eJwzALrSu8rQ== X-Google-Smtp-Source: ABdhPJwc1nbFhcPHi0y+6jFNObg+WQXsxOkhGb003NiPPJjXll80h+S/4WyNzRH508DiBDetQKm3xA== X-Received: by 2002:a7b:c013:: with SMTP id c19mr835095wmb.158.1625517269112; Mon, 05 Jul 2021 13:34:29 -0700 (PDT) Received: from Red ([2a01:cb1d:3d5:a100:264b:feff:fe03:2806]) by smtp.googlemail.com with ESMTPSA id c16sm14208870wru.24.2021.07.05.13.34.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Jul 2021 13:34:28 -0700 (PDT) Date: Mon, 5 Jul 2021 22:34:23 +0200 From: LABBE Corentin To: "Enrico Weigelt, metux IT consult" Cc: pavel@ucw.cz, robh+dt@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org Subject: Re: [PATCH] leds: remove ide-disk trigger Message-ID: References: <20210628191719.2823947-1-clabbe@baylibre.com> <1153e311-e0cf-d869-e3f8-b679eb2e60de@metux.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1153e311-e0cf-d869-e3f8-b679eb2e60de@metux.net> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le Tue, Jun 29, 2021 at 12:47:27PM +0200, Enrico Weigelt, metux IT consult a écrit : > On 28.06.21 21:17, Corentin Labbe wrote: > > > diff --git a/drivers/leds/trigger/ledtrig-disk.c b/drivers/leds/trigger/ledtrig-disk.c > > index 0741910785bb..38a5c21c0466 100644 > > --- a/drivers/leds/trigger/ledtrig-disk.c > > +++ b/drivers/leds/trigger/ledtrig-disk.c > > @@ -40,7 +40,6 @@ static int __init ledtrig_disk_init(void) > > led_trigger_register_simple("disk-activity", &ledtrig_disk); > > led_trigger_register_simple("disk-read", &ledtrig_disk_read); > > led_trigger_register_simple("disk-write", &ledtrig_disk_write); > > - led_trigger_register_simple("ide-disk", &ledtrig_ide); > > > > return 0; > > } > > Shouldn't this line also be removed ? > > DEFINE_LED_TRIGGER(ledtrig_ide); > Yes, I will send a v2. Thanks