From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF996C07E9E for ; Tue, 6 Jul 2021 04:40:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 929BD61209 for ; Tue, 6 Jul 2021 04:40:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230019AbhGFEmh (ORCPT ); Tue, 6 Jul 2021 00:42:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40304 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229926AbhGFEmf (ORCPT ); Tue, 6 Jul 2021 00:42:35 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE51AC061574; Mon, 5 Jul 2021 21:39:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Tm9bbwSLIXHzncYHK7SPpmMxLf8Q613BrbD6KMaacCU=; b=ZHopiEcE65spd6w6KieC7YH/9O 7KIMWJOGo8MuL0N/hif+7In1wZ4nMYAxts4WI+bThg19A1gHVk+zbNn2Pdxi3smtBEqehnkKz3sUg k27f5BUV881/+Qpx5UChOFiMXm9luIVQZi/+TgVqY8ogi4Oa/Q4lrsG/BS/5k2aBCiOEpB7lsIxGC 8Jzdbi9F6JmB7U+ZCCeU4u7wPa2bEo73kJeRXc2I+LSTTKq3IzhaQOjtTWzwJ7yX5yzQ5hKoD6zkY mJBkWTzUqrfkYMvY/Mxmr/0GsRBj026jW33bZuhIsz/UVAymC4vFNHkcOzqpC5t6HCwCADz2oI5fM /k80Alig==; Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1m0crl-00Apu4-QR; Tue, 06 Jul 2021 04:39:31 +0000 Date: Tue, 6 Jul 2021 05:39:25 +0100 From: Christoph Hellwig To: Jason Gunthorpe Cc: Leon Romanovsky , Shameerali Kolothum Thodi , Max Gurtovoy , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-crypto@vger.kernel.org" , "alex.williamson@redhat.com" , Linuxarm , liulongfang , "Zengtao (B)" , yuzenghui , Jonathan Cameron , "Wangzhou (B)" Subject: Re: [RFC v2 1/4] hisi-acc-vfio-pci: add new vfio_pci driver for HiSilicon ACC devices Message-ID: References: <20210702095849.1610-1-shameerali.kolothum.thodi@huawei.com> <20210702095849.1610-2-shameerali.kolothum.thodi@huawei.com> <834a009bba0d4db1b7a1c32e8f20611d@huawei.com> <20210705183247.GU4459@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210705183247.GU4459@nvidia.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 05, 2021 at 03:32:47PM -0300, Jason Gunthorpe wrote: > It would be improved a bit by making the ops struct mutable and > populating it at runtime like we do in RDMA. Then the PCI ops and > driver ops could be merged together without the repetition. No, that would be everything but an improvement.