From: Christoph Hellwig <hch@infradead.org>
To: Arnd Bergmann <arnd@arndb.de>,
Bernardo Innocenti <bernie@develer.com>,
"torvalds@linux-foundation.org Abd-Alrhman Masalkhi"
<abd.masalkhi@gmail.com>
Cc: hch@infradead.org, axboe@kernel.dk, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, dan.carpenter@oracle.com,
linux-parisc@vger.kernel.org
Subject: div_u64/do_div stack size usage, was Re: [v3] block: Removed a warning while compiling with a cross compiler for parisc
Date: Tue, 6 Jul 2021 18:01:38 +0100 [thread overview]
Message-ID: <YOSMct1YHs++E1vt@infradead.org> (raw)
In-Reply-To: <20210706153054.145461-1-abd.masalkhi@gmail.com>
On Tue, Jul 06, 2021 at 05:30:54PM +0200, Abd-Alrhman Masalkhi wrote:
> Thank you for your comment, the div_u64 function is called 5 times
> inside diskstats_show function, so I have made a test case; I have
> replaced one call with a constant number then I have compiled the
> kernel, the result was instead of emitting "the frame size of 1656
> bytes is larger than 1280 bytes" warning, it has emitted "the frame
> size of 1328 bytes is larger than 1280 bytes" warning, so I came to the
> conclusion that each call to div_u64 will add 328 bytes to the stack
> frame of diskstats_show function, since it is an inlined function. so I
> thought it might be the solution that to preventing div_u64 to be
> inlined in diskstats_show function.
Adding a bunch of relevant parties to the CC list - any idea how we
can make the generic do_div / div_u64 not use up such gigantic amounts
of stack?
next prev parent reply other threads:[~2021-07-06 17:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-06 11:19 [PATCH v3] block: Removed a warning while compiling with a cross compiler for parisc Abd-Alrhman Masalkhi
2021-07-06 13:59 ` Christoph Hellwig
2021-07-06 15:30 ` [v3] " Abd-Alrhman Masalkhi
2021-07-06 17:01 ` Christoph Hellwig [this message]
2021-07-06 17:35 ` div_u64/do_div stack size usage, was " Arnd Bergmann
2021-07-06 20:59 ` Abd-Alrhman Masalkhi
2021-07-07 8:17 ` Arnd Bergmann
2021-07-07 13:36 ` Helge Deller
2021-07-07 20:39 ` Arnd Bergmann
2021-07-08 9:29 ` Helge Deller
2021-07-08 11:37 ` Arnd Bergmann
2021-07-08 15:01 ` John David Anglin
2021-07-07 14:36 ` John David Anglin
2021-07-07 15:30 ` Abd-Alrhman Masalkhi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YOSMct1YHs++E1vt@infradead.org \
--to=hch@infradead.org \
--cc=abd.masalkhi@gmail.com \
--cc=arnd@arndb.de \
--cc=axboe@kernel.dk \
--cc=bernie@develer.com \
--cc=dan.carpenter@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).