* [PATCH v3 0/1] mm: sparse: pass section_nr to section_mark_present
[not found] <CGME20210707131841epcas1p2697afbb9f3e6e8040cb12f2f867329db@epcas1p2.samsung.com>
@ 2021-07-07 13:14 ` Ohhoon Kwon
[not found] ` <CGME20210707131841epcas1p129d1c10efdbbe403e80f45245b0b5afd@epcas1p1.samsung.com>
0 siblings, 1 reply; 3+ messages in thread
From: Ohhoon Kwon @ 2021-07-07 13:14 UTC (permalink / raw)
To: david, ohoono.kwon, akpm, mhocko
Cc: bhe, rppt, ohkwon1043, linux-mm, linux-kernel
Dear Michal.
I have updated my commit as suggested in your review feedback.
Please check if the change looks okay.
I temporarily separated the mail thread since re-sending mails for the full
patchset might seem as spam.
If you confirm, then I will merge this change with other patches and
re-send the full patchset again.
Thanks,
Ohhoon Kwon.
Ohhoon Kwon (1):
mm: sparse: pass section_nr to section_mark_present
mm/sparse.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v3 1/1] mm: sparse: pass section_nr to section_mark_present
[not found] ` <CGME20210707131841epcas1p129d1c10efdbbe403e80f45245b0b5afd@epcas1p1.samsung.com>
@ 2021-07-07 13:14 ` Ohhoon Kwon
2021-07-07 14:32 ` ***UNCHECKED*** " Michal Hocko
0 siblings, 1 reply; 3+ messages in thread
From: Ohhoon Kwon @ 2021-07-07 13:14 UTC (permalink / raw)
To: david, ohoono.kwon, akpm, mhocko
Cc: bhe, rppt, ohkwon1043, linux-mm, linux-kernel
With CONFIG_SPARSEMEM_EXTREME enabled, __section_nr() which converts
mem_section to section_nr could be costly since it iterates all
section roots to check if the given mem_section is in its range.
Since both callers of section_mark_present already know section_nr,
let's also pass section_nr as well as mem_section in order to reduce
costly translation.
Signed-off-by: Ohhoon Kwon <ohoono.kwon@samsung.com>
Acked-by: Mike Rapoport <rppt@linux.ibm.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
---
mm/sparse.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/mm/sparse.c b/mm/sparse.c
index 6326cdf36c4f..8018ee7fcda5 100644
--- a/mm/sparse.c
+++ b/mm/sparse.c
@@ -187,10 +187,9 @@ void __meminit mminit_validate_memmodel_limits(unsigned long *start_pfn,
* those loops early.
*/
unsigned long __highest_present_section_nr;
-static void section_mark_present(struct mem_section *ms)
+static void __section_mark_present(struct mem_section *ms,
+ unsigned long section_nr)
{
- unsigned long section_nr = __section_nr(ms);
-
if (section_nr > __highest_present_section_nr)
__highest_present_section_nr = section_nr;
@@ -280,7 +279,7 @@ static void __init memory_present(int nid, unsigned long start, unsigned long en
if (!ms->section_mem_map) {
ms->section_mem_map = sparse_encode_early_nid(nid) |
SECTION_IS_ONLINE;
- section_mark_present(ms);
+ __section_mark_present(ms, section);
}
}
}
@@ -934,7 +933,7 @@ int __meminit sparse_add_section(int nid, unsigned long start_pfn,
ms = __nr_to_section(section_nr);
set_section_nid(section_nr, nid);
- section_mark_present(ms);
+ __section_mark_present(ms, section_nr);
/* Align memmap to section boundary in the subsection case */
if (section_nr_to_pfn(section_nr) != start_pfn)
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: ***UNCHECKED*** [PATCH v3 1/1] mm: sparse: pass section_nr to section_mark_present
2021-07-07 13:14 ` [PATCH v3 1/1] " Ohhoon Kwon
@ 2021-07-07 14:32 ` Michal Hocko
0 siblings, 0 replies; 3+ messages in thread
From: Michal Hocko @ 2021-07-07 14:32 UTC (permalink / raw)
To: Ohhoon Kwon; +Cc: david, akpm, bhe, rppt, ohkwon1043, linux-mm, linux-kernel
On Wed 07-07-21 22:14:43, Ohhoon Kwon wrote:
> With CONFIG_SPARSEMEM_EXTREME enabled, __section_nr() which converts
> mem_section to section_nr could be costly since it iterates all
> section roots to check if the given mem_section is in its range.
>
> Since both callers of section_mark_present already know section_nr,
> let's also pass section_nr as well as mem_section in order to reduce
> costly translation.
>
> Signed-off-by: Ohhoon Kwon <ohoono.kwon@samsung.com>
> Acked-by: Mike Rapoport <rppt@linux.ibm.com>
> Reviewed-by: David Hildenbrand <david@redhat.com>
I would simply fold that into the first patch but a separate patch is
also OK.
Acked-by: Michal Hocko <mhocko@suse.com>
Thanks
> ---
> mm/sparse.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/mm/sparse.c b/mm/sparse.c
> index 6326cdf36c4f..8018ee7fcda5 100644
> --- a/mm/sparse.c
> +++ b/mm/sparse.c
> @@ -187,10 +187,9 @@ void __meminit mminit_validate_memmodel_limits(unsigned long *start_pfn,
> * those loops early.
> */
> unsigned long __highest_present_section_nr;
> -static void section_mark_present(struct mem_section *ms)
> +static void __section_mark_present(struct mem_section *ms,
> + unsigned long section_nr)
> {
> - unsigned long section_nr = __section_nr(ms);
> -
> if (section_nr > __highest_present_section_nr)
> __highest_present_section_nr = section_nr;
>
> @@ -280,7 +279,7 @@ static void __init memory_present(int nid, unsigned long start, unsigned long en
> if (!ms->section_mem_map) {
> ms->section_mem_map = sparse_encode_early_nid(nid) |
> SECTION_IS_ONLINE;
> - section_mark_present(ms);
> + __section_mark_present(ms, section);
> }
> }
> }
> @@ -934,7 +933,7 @@ int __meminit sparse_add_section(int nid, unsigned long start_pfn,
>
> ms = __nr_to_section(section_nr);
> set_section_nid(section_nr, nid);
> - section_mark_present(ms);
> + __section_mark_present(ms, section_nr);
>
> /* Align memmap to section boundary in the subsection case */
> if (section_nr_to_pfn(section_nr) != start_pfn)
> --
> 2.17.1
--
Michal Hocko
SUSE Labs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-07 14:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20210707131841epcas1p2697afbb9f3e6e8040cb12f2f867329db@epcas1p2.samsung.com>
2021-07-07 13:14 ` [PATCH v3 0/1] mm: sparse: pass section_nr to section_mark_present Ohhoon Kwon
[not found] ` <CGME20210707131841epcas1p129d1c10efdbbe403e80f45245b0b5afd@epcas1p1.samsung.com>
2021-07-07 13:14 ` [PATCH v3 1/1] " Ohhoon Kwon
2021-07-07 14:32 ` ***UNCHECKED*** " Michal Hocko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).