From: David Matlack <dmatlack@google.com>
To: David Edmondson <david.edmondson@oracle.com>
Cc: linux-kernel@vger.kernel.org, Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>,
Sean Christopherson <seanjc@google.com>,
Borislav Petkov <bp@alien8.de>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Joerg Roedel <joro@8bytes.org>,
kvm@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
x86@kernel.org, Ingo Molnar <mingo@redhat.com>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH v2 0/2] kvm: x86: Convey the exit reason to user-space on emulation failure
Date: Wed, 7 Jul 2021 23:20:04 +0000 [thread overview]
Message-ID: <YOY2pLoXQ8ePXu0W@google.com> (raw)
In-Reply-To: <20210706101207.2993686-1-david.edmondson@oracle.com>
On Tue, Jul 06, 2021 at 11:12:05AM +0100, David Edmondson wrote:
> To help when debugging failures in the field, if instruction emulation
> fails, report the VM exit reason to userspace in order that it can be
> recorded.
What is the benefit of seeing the VM-exit reason that led to an
emulation failure?
>
> I'm unsure whether sgx_handle_emulation_failure() needs to be adapted
> to use the emulation_failure part of the exit union in struct kvm_run
> - advice welcomed.
>
> v2:
> - Improve patch comments (dmatlack)
> - Intel should provide the full exit reason (dmatlack)
> - Pass a boolean rather than flags (dmatlack)
> - Use the helper in kvm_task_switch() and kvm_handle_memory_failure()
> (dmatlack)
> - Describe the exit_reason field of the emulation_failure structure
> (dmatlack)
>
> David Edmondson (2):
> KVM: x86: Add kvm_x86_ops.get_exit_reason
> KVM: x86: On emulation failure, convey the exit reason to userspace
>
> arch/x86/include/asm/kvm-x86-ops.h | 1 +
> arch/x86/include/asm/kvm_host.h | 3 +++
> arch/x86/kvm/svm/svm.c | 6 ++++++
> arch/x86/kvm/vmx/vmx.c | 11 +++++++----
> arch/x86/kvm/x86.c | 22 +++++++++++++---------
> include/uapi/linux/kvm.h | 7 +++++++
> 6 files changed, 37 insertions(+), 13 deletions(-)
>
> --
> 2.30.2
>
next prev parent reply other threads:[~2021-07-07 23:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-06 10:12 [PATCH v2 0/2] kvm: x86: Convey the exit reason to user-space on emulation failure David Edmondson
2021-07-06 10:12 ` [PATCH v2 1/2] KVM: x86: Add kvm_x86_ops.get_exit_reason David Edmondson
2021-07-06 10:12 ` [PATCH v2 2/2] KVM: x86: On emulation failure, convey the exit reason to userspace David Edmondson
2021-07-09 15:47 ` Sean Christopherson
2021-07-12 15:34 ` David Edmondson
2021-07-07 23:20 ` David Matlack [this message]
2021-07-08 14:17 ` [PATCH v2 0/2] kvm: x86: Convey the exit reason to user-space on emulation failure David Edmondson
2021-07-08 18:38 ` David Matlack
2021-07-08 20:13 ` David Edmondson
2021-07-08 20:35 ` David Matlack
2021-07-09 16:08 ` Sean Christopherson
2021-07-07 23:22 ` David Matlack
2021-07-08 14:20 ` David Edmondson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YOY2pLoXQ8ePXu0W@google.com \
--to=dmatlack@google.com \
--cc=bp@alien8.de \
--cc=david.edmondson@oracle.com \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).